Skip to content

Clarify relationship between project and directory names #9830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

drewnoakes
Copy link
Member

The project name does not have to match the directory name, although they are usually created in this way. I feel this change makes it clearer where the default <AssemblyName> and <PackageId> properties come from.

A subject matter expert should confirm this however.

The project name does not have to match the directory name, although they are usually created in this way. I feel this change makes it clearer where the default `<AssemblyName>` and `<PackageId>` properties come from.
@drewnoakes drewnoakes requested a review from mairaw as a code owner January 4, 2019 17:07
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @drewnoakes We appreciate it.

I've reviewed the change, and I'll :shipit: now.

Thanks for contributing again to docs!

@BillWagner BillWagner merged commit 904a8f7 into dotnet:master Feb 22, 2019
@drewnoakes drewnoakes deleted the patch-3 branch February 25, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants