Skip to content

Porting from MSDN #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2016
Merged

Porting from MSDN #975

merged 3 commits into from
Aug 29, 2016

Conversation

stevehoag
Copy link
Contributor

Previously reviewed for content

Previously reviewed for content
@stevehoag
Copy link
Contributor Author

@mairaw Build is complete and now showing up on stage. All previous issues addressed. Finally ready to merge?

@mairaw
Copy link
Contributor

mairaw commented Aug 26, 2016

Ok, things are looking good now. But I do have another question now:

  • You moved the content of the gc-overview file to the index one inside garbagecollection right?
    So now we have two topics with the same GUID. You should apply the redirection metadata to the original one since folks could have links to that.

@stevehoag
Copy link
Contributor Author

stevehoag commented Aug 27, 2016

@mairaw Shouldn't be a problem - I found one topic that was linking to it and fixed the broken link.
And actually it was the other way around - I copied the contents of the old index file into gc_overview, then moved it and renamed it to index.

@mairaw
Copy link
Contributor

mairaw commented Aug 27, 2016

But you now have two valid topics with the same GUID and the old one is still searchable and reachable, just not on the TOC. You need to apply the redirect on the old one.

@qinezh
Copy link
Contributor

qinezh commented Aug 29, 2016

Open Publishing Build Service: The pull request content has been published and here are some sample preview links:

@mairaw
Copy link
Contributor

mairaw commented Aug 29, 2016

LGTM

@stevehoag stevehoag merged commit bb50b16 into dotnet:master Aug 29, 2016
@stevehoag
Copy link
Contributor Author

Closes #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants