Skip to content

Clarify PackageReference attributes #9536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Clarify PackageReference attributes #9536

merged 2 commits into from
Feb 22, 2019

Conversation

kkm000
Copy link
Contributor

@kkm000 kkm000 commented Dec 11, 2018

Summary

  • Cross-reference the full PackageReference documentation topic from the first sentence.
  • Update an existing link to the NuGet versioning topic (skip a redirect).
  • Note that the Version attribute is required, and mention the defaults for the other, optional attributes.

* Cross-reference the full PackageReference documentation topic
  from the first sentence.
* Update an existing link to the NuGet versioning topic (skip a
  redirect).
* Note that the Version attribute is required, and mention the
  defaults for the other, optional attributes.
@kkm000 kkm000 requested a review from mairaw as a code owner December 11, 2018 08:10
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @kkm000

I'll :shipit: now.

You should see the changes on the live site in the next few days, on our regular publishing cycle.

@BillWagner BillWagner merged commit ba6d4dd into dotnet:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants