Skip to content

Conversation

@matthewreily
Copy link

Looking for some feedback on the structure of this example. I went out and grabbed one of the examples from the linq 101 msdn site https://code.msdn.microsoft.com/101-LINQ-Samples-3fb9811b. With this sample I created 2 methods to show both the linq query and method syntax. Is this how we should go about it or should we just show one version of the syntax?

@matthewreily
Copy link
Author

This is for #90 @BethMassi

@BethMassi
Copy link
Contributor

@matthewreily thanks for this. We want to be able to run these samples against the latest coreclr runtime so we need a couple things. First, we'll need to add a main entry point so I think we should have a program.cs file for each project.json we have. Something like:

public class Program
{
public void Main(string[] args)
{
var sample = new WhereClause1();
sample.QuerySyntaxExample();
sample.MethodSyntaxExample();
}
}

Next, it looks like we'll need to specify "dnxcore50" in the frameworks section of the project.json. Then we should be able to "dnvm upgrade latest -r coreclr -u" and then "dnx run" in the sample folder.

Can you fix your PR?

@BethMassi
Copy link
Contributor

I created step-by-step instructions here: https://github.com/dotnet/core-docs/blob/master/samples/README.md

Hope this helps! 😄

@matthewreily
Copy link
Author

You are amazing @BethMassi! Thank you for your help. I noticed one issue in the readme.md in regards to the version of system.console. I recieved an error "Unable to locate Dependency System.Console >= 4.0.0-rc1-" when running dnu restore. I updated my project.json to use the 4.0.0-Beta- version

BethMassi added a commit that referenced this pull request Nov 5, 2015
@BethMassi BethMassi merged commit 7cc8a8d into dotnet:master Nov 5, 2015
v-maudel added a commit to v-maudel/docs-1 that referenced this pull request Jul 5, 2018
Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
"&dotnet#91; and &dotnet#93; are the codes used to create "[" and "]" characters. However, when it is localized it is shown as &dotnet#91; and &dotnet#93; breaking the code"

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.

Many thanks in advance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants