Skip to content

Add MSTest tutorial (#915) #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 30, 2016
Merged

Conversation

ncarandini
Copy link
Contributor

Summary

An article to show how to use MSTest instead of xUnit to write the test project contained on the Getting started with .NET Core on Windows tutorial.

Fixes #915

Suggested Reviewers

@BillWagner

@dnfclas
Copy link

dnfclas commented Aug 18, 2016

Hi @ncarandini, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Aug 18, 2016

@ncarandini, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;


by [Nicolò Caradini](https://github.com/ncarandini)

While xUnit could be a better choice when targeting multiple platforms, with .NET Core on Windows is also possible to use MSUnit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "MSTest" instead of "MSUnit"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@BillWagner
Copy link
Member

@ncarandini Thanks for writing this. It's very much on the right track.

I left some feedback on a few items to update. Then as you finish up, I think it will be ready.

@qinezh
Copy link
Contributor

qinezh commented Aug 29, 2016

Open Publishing Build Service: The pull request content has been published and here are some sample preview links:

@ncarandini
Copy link
Contributor Author

@BillWagner Thanks for reviewing, I've done all required changes. Now two questions:

Where to put it

Looking at the docs structure I see two candidated places:

  • .NET Core Guide | Tutorials | Use MSTest with .NET Core on Windows
  • .NET Core Guide | Unit Testing | Use MSTest with .NET Core on Windows

Were to put links to it

Because is strictly related to Windows scenario, we can create a link in the Getting started with .NET Core on Windows article, at the end of Writing the test project section.
We can also create a link in the Unit Testing in .NET Core, right at the end.

@BillWagner
Copy link
Member

@ncarandini Thanks for all the work on this.

Let's put it here:

.NET Core Guide | Unit Testing | Use MSTest with .NET Core on Windows

I agree with both your suggestions on links:

We can create a link in the Getting started with .NET Core on Windows article, at the end of Writing the test project section.
We can also create a link in the Unit Testing in .NET Core, right at the end.

You should also update docs/toc.md to provide an entry under .NET Core Guide | Unit Testing.

Then, it will show up in the left nav.

Once those links are added, I'll give it one last review and merge it.
Thanks again!

@BillWagner BillWagner removed the WIP label Aug 30, 2016
@qinezh
Copy link
Contributor

qinezh commented Aug 30, 2016

Open Publishing Build Service: The pull request content has been published and here are some sample preview links:

@BillWagner
Copy link
Member

@ncarandini Thanks for that last update. This is great content.

:shipit: 🎆

@BillWagner BillWagner merged commit 1b8fcea into dotnet:master Aug 30, 2016
@ncarandini
Copy link
Contributor Author

@BillWagner Thanks, this has been a great experience for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants