-
Notifications
You must be signed in to change notification settings - Fork 6k
Add MSTest tutorial (#915) #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ncarandini, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
@ncarandini, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
||
by [Nicolò Caradini](https://github.com/ncarandini) | ||
|
||
While xUnit could be a better choice when targeting multiple platforms, with .NET Core on Windows is also possible to use MSUnit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be "MSTest" instead of "MSUnit"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@ncarandini Thanks for writing this. It's very much on the right track. I left some feedback on a few items to update. Then as you finish up, I think it will be ready. |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@BillWagner Thanks for reviewing, I've done all required changes. Now two questions: Where to put itLooking at the docs structure I see two candidated places:
Were to put links to itBecause is strictly related to Windows scenario, we can create a link in the Getting started with .NET Core on Windows article, at the end of Writing the test project section. |
@ncarandini Thanks for all the work on this. Let's put it here:
I agree with both your suggestions on links:
You should also update docs/toc.md to provide an entry under .NET Core Guide | Unit Testing. Then, it will show up in the left nav. Once those links are added, I'll give it one last review and merge it. |
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
@ncarandini Thanks for that last update. This is great content.
|
@BillWagner Thanks, this has been a great experience for me! |
Summary
An article to show how to use MSTest instead of xUnit to write the test project contained on the Getting started with .NET Core on Windows tutorial.
Fixes #915
Suggested Reviewers
@BillWagner