Skip to content

Cross updating with Microservices eBook v2.1.02 - Dropped sections #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mvelosop
Copy link
Contributor

Summary

Drop section removed from the e-book:

  • Deploying Single-Container-Based .NET Core Web Applications on Linux or Windows Nano Server Hosts
  • Migrating Legacy Monolithic .NET Framework Applications to Windows Containers

No issues fixed here

…moved from the e-book ("Deploying Single Container apps" and "Migrating Legacy Monolithic apps")
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple other locations in this eBook where the removed files were referenced. Can you remove these links:

Warning Unspecified InvalidFileLink docs/standard/microservices-architecture/docker-application-development-process/docker-app-development-workflow.md Invalid file link:(~/docs/standard/microservices-architecture/net-core-single-containers-linux-windows-server-hosts/index.md). BuildCore.Build Document.LinkPhaseHandlerWithIncremental.ConceptualDocumentProcessor.Save 445 09/28/2018 15:52:53
Warning Unspecified InvalidFileLink docs/standard/microservices-architecture/multi-container-microservice-net-applications/index.md Invalid file link:(~/docs/standard/microservices-architecture/containerize-net-framework-applications/index.md). BuildCore.Build Document.LinkPhaseHandlerWithIncremental.ConceptualDocumentProcessor.Save 18 09/28/2018 15:52:53

After that, it's ready to merge.

@mvelosop
Copy link
Contributor Author

mvelosop commented Oct 3, 2018

Hi @BillWagner,

Those have been addressed already, just waiting to be merged:

  1. First in commit 16af73f
  2. Second in commit 21ab90d (here)

Best.

@BillWagner
Copy link
Member

Thanks for the note @mvelosop

Is the first one part of a PR? I'll review that as well, and get all of them merged.

@mvelosop
Copy link
Contributor Author

mvelosop commented Oct 3, 2018

Yes @BillWagner, the first one is part of chapter 5's PR: #7943

@BillWagner
Copy link
Member

@mvelosop I apologize for dropping the ball on this one.

Is this ready to merge?

@mvelosop
Copy link
Contributor Author

Hi @BillWagner, no problem. Yep, it's ready to merge, this is also linked to PR #7943 for the right next/previous links.

@BillWagner BillWagner merged commit 1b7bf59 into dotnet:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants