Update VS Tools for Docker topic #7214

gewarren · 2018-08-22T21:11:50Z

update/standardize links
remove VS 2015 section
add alt text for images, and remove "figure" labels
acrolinx-type stuff
add See also section

Part of the fix for #7172.

mairaw · 2018-08-23T16:46:15Z

...vices-architecture/docker-application-development-process/docker-app-development-workflow.md

-   **aspnet-docker/Dockerfile.** Example Powershell commands to run from dockerfiles to include Windows features.
-    [*https://github.com/Microsoft/aspnet-docker/blob/master/4.6.2/Dockerfile*](https://github.com/Microsoft/aspnet-docker/blob/master/4.6.2/Dockerfile)
+- Example Powershell commands to run from dockerfiles to include Windows features -
+    [aspnet-docker/Dockerfile](https://github.com/Microsoft/aspnet-docker/blob/master/4.6.2/Dockerfile)


there are some things that are special about the e-books @gewarren. like in this case because the content is also printed in a book, some urls are displayed in full in the additional resources list so I wouldn't standardize links for this set of content

mairaw · 2018-08-23T16:49:31Z

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md


-With the latest versions of Docker for Windows, it is easier than ever to develop Docker applications because the setup is straightforward, as explained in the following references.
+With the latest versions of [Docker for Windows](https://docs.docker.com/docker-for-windows/), it is easier than ever to develop Docker applications because the setup is straightforward.


nit: it is -> it's

The URL needs to show up in the text for print.

gewarren · 2018-08-23T17:04:59Z

Okay. How do I know if a topic is part of an e-book?

CESARDELATORRE · 2018-08-23T20:25:56Z

I think it is good, but in addition to those changes, I think we could eliminate all the content and references to VS 2015. That content was created when VS 2017 was being released, but it is now late 2018, so I think we should get rid of the content mentioning VS 2015 because especially when targeting Docker, VS 2015 is really out of the game.. No one uses VS 2015 for Docker development. Many things won't work properly.

mairaw · 2018-08-24T01:21:47Z

@gewarren:

Okay. How do I know if a topic is part of an e-book?

First, that's the only place that will have these different links.
But here you can see all the paths tagged as dotnet-ebooks. So that would the ms.technology of those topics online.
https://github.com/dotnet/docs/blob/master/docfx.json#L185

gewarren · 2018-08-25T01:10:37Z

I am OOF next week but this is ready to go from my POV.

mairaw · 2018-08-28T22:48:13Z

@lisaguthrie do you wanna review this PR and make sure the topic looks good to you?

Review URL: https://review.docs.microsoft.com/en-us/dotnet/standard/containerized-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker?branch=pr-en-us-7214

lisaguthrie · 2018-08-30T02:20:42Z

Removal of the 2015 references is good, but the remaining text still isn't accurate for VS 15.8+. With that version, "Add Docker Support" (or selecting the "Enable Docker Support" checkbox when creating a new project) ONLY adds a Dockerfile. All the docker-compose stuff is not there. The easiest way to add docker-compose stuff is to select Add Container Orchestration Support (on the same menu as Add Docker Support) on a new or existing project. You can also do Enable Docker Support on a new project and then do Add Container Orchestration Support, but Add Container Orchestration Support will also add a Dockerfile.

gewarren · 2018-09-04T23:24:17Z

@ghogen Can you take a look at the visual-studio-tools-for-docker.md changes?

ghogen · 2018-09-04T23:26:54Z

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md


 Docker support is included in Visual Studio 2017. Download Visual Studio 2017 here: [https://aka.ms/vsdownload?utm_source=mscom&utm_campaign=msdocs](https://aka.ms/vsdownload?utm_source=mscom&utm_campaign=msdocs)

 ## Use Docker Tools in Visual Studio 2017

-When you add Docker support to a service project in your solution, Visual Studio doesn't just add a DockerFile file to your project, it also adds a service section in your solution's *docker-compose.yml* files (or creates the files if they didn't exist). It's an easy way to begin composing your multicontainer solution. You can then open the *docker-compose.yml* files and update them with additional features.
+When you add Docker support to a web app project, Visual Studio adds a DockerFile file to the project. When you add container orchestrator support, Visual Studio not only adds a DockerFile to the project, but also a global docker-compose.yml file at the solution level. If *docker-compose.yml* already exists, Visual Studio adds the required lines of configuration code to it. It's an easy way to begin composing your multicontainer solution. You can then open the *docker-compose.yml* file and update it with additional features.


You could add * around docker-compose.yml here and in a few other places.

ghogen · 2018-09-04T23:39:33Z

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md

 ---
 # Use Visual Studio Tools for Docker (Visual Studio on Windows)

-The developer workflow when using Visual Studio Tools for Docker is similar to the workflow when using Visual Studio Code and Docker CLI (it is based on the same Docker CLI). Visual Studio Tools for Docker makes it even easier to get started, simplifies the process, and provides greater productivity for the build, run, and compose tasks. It's also able to execute and debug your containers via simple actions like **F5** and **Ctrl**+**F5**. You can also run and debug a group of containers (a whole solution) at the same time if they're defined in the same *docker-compose.yml* file at the solution level.
+The Visual Studio Tools for Docker developer workflow is similar to using Visual Studio Code and Docker CLI (it is based on the same Docker CLI). Visual Studio Tools for Docker makes it even easier to get started, simplifies the process, and provides greater productivity for the build, run, and compose tasks. Execute and debug your containers via simple actions like **F5** and **Ctrl**+**F5**. You can also run and debug a group of containers (a whole solution) at the same time if they're defined in the same *docker-compose.yml* file at the solution level.


I think the last sentence here about docker-compose.yml should be removed or put into a separate paragraph that deals specifically with the less-common "Container Orchestratration" option. It's confusing to see it mentioned here for users that don't choose that more complex option.

…sual-studio-tools-for-docker

gewarren · 2018-09-05T22:17:17Z

@lisaguthrie @CESARDELATORRE I think this is good to go now. Can you give it a final look?

https://review.docs.microsoft.com/en-us/dotnet/standard/containerized-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker?branch=pr-en-us-7214

https://review.docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/docker-application-development-process/docker-app-development-workflow?branch=pr-en-us-7214

lisaguthrie · 2018-09-05T22:41:54Z

Looking good! One thing, which I'm not sure we want to get into in a lot of depth, is that all of this applies to .NET Core apps. Full framework apps still use the docker-compose approach; there's no option to have just a Dockerfile. Perhaps just put a note at the top of both articles indicating that .NET Framework web apps will use docker-compose?

In the first article, if you do add container orchestration support and you already have a Dockerfile, we won't overwrite it. It only creates a Dockerfile if one is not available already.

In the second article, step 5 option A "running a single app Docker container," you can do this from VS as well: If you haven't added container orchestration support, an F5 will run the container locally using docker run.

gewarren · 2018-09-06T00:20:34Z

@lisaguthrie So to clarify, in .NET Framework web apps, you can only add container orchestrator support. In .NET Core web apps, you can either add Docker support (Dockerfile) or container orchestrator support. Prior to version 15.8, there was no option to just add a Dockerfile in a .NET Core web app. Is that correct?

gewarren · 2018-09-06T20:13:25Z

@ghogen I think you are looking at an old diff. Can you refresh?

ghogen · 2018-09-06T20:20:41Z

@gewarren I'm not sure that the Full Framework scenario, I'm trying to verify that on a recent build. It's not clear to me yet whether there's an "Add Docker support" that adds docker-compose stuff, or whether it's just the Add Container Orchestration. I think it would be the former, but this version of the doc seems to be saying it's the latter.

ghogen · 2018-09-06T20:31:33Z

@gewarren ok checked a build and confirmed that your version in this doc is correct, thanks. I used a .NET 4.7.2 Web Application MVC project. The option on the New Project dialog was "Enable Docker Compose Support" and the Add menu has "Container Orchestration Support" as an option, but not "Docker support".

gewarren · 2018-09-07T17:31:44Z

@ghogen Thanks for reviewing!

gewarren · 2018-09-17T16:29:49Z

@lisaguthrie Do you want to give this a final review? At this point it's just stagnating here so would be great to get it merged.

lisaguthrie · 2018-09-18T18:18:31Z

@gewarren thanks for the ping! It looks good :)

gewarren · 2018-09-18T21:35:55Z

@ghogen I'm not sure what to do with the VS tools for Docker topic in this PR. It looks like you already updated it :( Should I just remove the topic from this PR?

ghogen · 2018-09-18T22:15:03Z

@gewarren Your changes have been reviewed by PMs and approved, so let's go with those. I can then integrate any of mine on top of that.

gewarren · 2018-09-18T22:39:17Z

@mairaw Can you sign off on this so I can merge it? Thanks!

mairaw

Thanks @gewarren. Left some comments. This content is a bit different because they're part of the e-book series so they have some different styles.

...vices-architecture/docker-application-development-process/docker-app-development-workflow.md

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md

...vices-architecture/docker-application-development-process/docker-app-development-workflow.md

mairaw · 2018-09-19T01:38:25Z

...vices-architecture/docker-application-development-process/docker-app-development-workflow.md


-**Figure 5-13**. Example of testing your Docker application locally using localhost
+![Example of testing your Docker application locally using localhost](./media/image18.png)


because this is a book, this needs to have these numbered figures as well

gewarren · 2018-09-19T19:17:38Z

@mairaw Thanks for the review. I've addressed everything and reviewed on staging.

gewarren · 2018-09-20T19:53:30Z

@mairaw - ping on this.

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md

mairaw · 2018-09-20T21:31:38Z

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md


-To see more about installing Visual Studio Tools for Docker, go to <http://aka.ms/vstoolsfordocker> and <https://docs.microsoft.com/aspnet/core/host-and-deploy/docker/visual-studio-tools-for-docker>.
+There are two levels of Docker support you can add to a project. In .NET Core web app projects, you can just add a *Dockerfile* file to the project by enabling Docker support. The next level is container orchestrator support, which adds a *Dockerfile* to the project (if it doesn't already exist) and a *docker-compose.yml* file at the solution level.


@lisaguthrie from the talk today, my understanding is that you don't have the docker-compose file anymore and all you get is the Dockerfile. Is that correct?

I think that is incorrect, based on my most recent info from Lisa.

mairaw

Feel free to squash and merge when you're ready @gewarren.

gewarren · 2018-09-25T00:00:08Z

@mairaw Thanks! Merging now.

gewarren · 2018-09-25T00:01:00Z

@ghogen This has been merged now if you want to add in your updates.

update vs tools for docker topic

14bb9e3

gewarren changed the title ~~Update vs tools for docker topic~~ Update VS Tools for Docker topic Aug 22, 2018

gewarren added 2 commits August 22, 2018 14:40

update a second docker topic; update dates

5255432

review on staging

fd79535

mairaw reviewed Aug 23, 2018

View reviewed changes

mairaw requested a review from CESARDELATORRE August 23, 2018 16:47

mairaw reviewed Aug 23, 2018

View reviewed changes

gewarren added 2 commits August 23, 2018 17:58

add link URLs into link text; remove VS 2015 sections

8c261f0

add one more URL and fix nit

be768bd

review on staging

ac9bf76

update docker-compose for vs version 15.8

af5b5c2

ghogen reviewed Sep 4, 2018

View reviewed changes

gewarren added 4 commits September 5, 2018 10:46

gordon's edits

ba96de6

update screenshots in docker-app-development-workflow; add h3's to vi…

af25445

…sual-studio-tools-for-docker

update dates

fd8456f

review on staging

620c9ab

gewarren added 3 commits September 5, 2018 19:02

add clarification about .net fx versus .net core

27b8f71

acrolinx; add gray border around two screenshots

322fbf6

merge from master

0e48e93

gewarren added 2 commits September 18, 2018 15:36

merge from upstream

48cbdfd

Merge branch 'vs-docker' of github.com:gewarren/docs into vs-docker

cc99210

mairaw requested changes Sep 19, 2018

View reviewed changes

gewarren added 4 commits September 18, 2018 19:18

review from maira

777c4e5

Merge branch 'vs-docker' of github.com:gewarren/docs into vs-docker

007058e

remainder of maira's review comments

b777b9e

add missing figure label

8d31c30

mairaw reviewed Sep 20, 2018

View reviewed changes

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md Outdated Show resolved Hide resolved

mairaw reviewed Sep 20, 2018

View reviewed changes

...d-lifecycle-architecture/design-develop-containerized-apps/visual-studio-tools-for-docker.md Outdated Show resolved Hide resolved

mairaw reviewed Sep 20, 2018

View reviewed changes

gewarren added 2 commits September 20, 2018 14:50

add figure labels back

fa1ebcf

Merge branch 'vs-docker' of github.com:gewarren/docs into vs-docker

5c4de5b

mairaw approved these changes Sep 24, 2018

View reviewed changes

mairaw mentioned this pull request Sep 24, 2018

Documentation needs to be updated to reflect VS 15.8+ #7341

Closed

gewarren merged commit ac28966 into dotnet:master Sep 25, 2018

mvelosop mentioned this pull request Sep 25, 2018

Synchronize updates from PR #7214 into Microservices e-book chapter 5 #7888

Closed

gewarren deleted the vs-docker branch October 21, 2019 20:06


		With the latest versions of Docker for Windows, it is easier than ever to develop Docker applications because the setup is straightforward, as explained in the following references.
		With the latest versions of [Docker for Windows](https://docs.docker.com/docker-for-windows/), it is easier than ever to develop Docker applications because the setup is straightforward.


		Figure 5-13. Example of testing your Docker application locally using localhost
		![Example of testing your Docker application locally using localhost](./media/image18.png)


		To see more about installing Visual Studio Tools for Docker, go to <http://aka.ms/vstoolsfordocker> and <https://docs.microsoft.com/aspnet/core/host-and-deploy/docker/visual-studio-tools-for-docker>.
		There are two levels of Docker support you can add to a project. In .NET Core web app projects, you can just add a Dockerfile file to the project by enabling Docker support. The next level is container orchestrator support, which adds a Dockerfile to the project (if it doesn't already exist) and a docker-compose.yml file at the solution level.

Update VS Tools for Docker topic #7214

Update VS Tools for Docker topic #7214

Uh oh!

Conversation

gewarren commented Aug 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mairaw Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mairaw Aug 23, 2018

Choose a reason for hiding this comment

Uh oh!

gewarren commented Aug 23, 2018

Uh oh!

CESARDELATORRE commented Aug 23, 2018

Uh oh!

mairaw commented Aug 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gewarren commented Aug 25, 2018

Uh oh!

mairaw commented Aug 28, 2018

Uh oh!

lisaguthrie commented Aug 30, 2018

Uh oh!

gewarren commented Sep 4, 2018

Uh oh!

ghogen Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

ghogen Sep 4, 2018

Choose a reason for hiding this comment

Uh oh!

gewarren commented Sep 5, 2018

Uh oh!

lisaguthrie commented Sep 5, 2018

Uh oh!

gewarren commented Sep 6, 2018

Uh oh!

gewarren commented Sep 6, 2018

Uh oh!

ghogen commented Sep 6, 2018

Uh oh!

ghogen commented Sep 6, 2018

Uh oh!

gewarren commented Sep 7, 2018

Uh oh!

gewarren commented Sep 17, 2018

Uh oh!

lisaguthrie commented Sep 18, 2018

Uh oh!

gewarren commented Sep 18, 2018

Uh oh!

ghogen commented Sep 18, 2018

Uh oh!

gewarren commented Sep 18, 2018

Uh oh!

mairaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mairaw Sep 19, 2018

Choose a reason for hiding this comment

Uh oh!

gewarren commented Sep 19, 2018

Uh oh!

gewarren commented Sep 20, 2018

Uh oh!

Uh oh!

Uh oh!

mairaw Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

gewarren Sep 20, 2018

gewarren commented Aug 22, 2018 •

edited

Loading

mairaw Aug 23, 2018 •

edited

Loading

mairaw commented Aug 24, 2018 •

edited

Loading