Fix broken link #6516
Fix broken link #6516
Conversation
| [*https://github.com/aspnet/Hosting/tree/dev/samples/GenericHostSample*](https://github.com/aspnet/Hosting/tree/dev/samples/GenericHostSample) | ||
|
|
||
|
|
||
| [*https://github.com/aspnet/Hosting/tree/release/2.1/samples/GenericHostSample*](https://github.com/aspnet/Hosting/tree/release/2.1/samples/GenericHostSample) |
There was a problem hiding this comment.
I would recommend using a canonical link instead. This original link was broken because we deleted the dev branch. We might delete release/2.1 at some point.
There was a problem hiding this comment.
That's a pretty ugly URL to show to customers given the whole URL is printed in these e-books 😄
If you get to the point of deleting that branch, it would probably be time for reviewing this topic no?
There was a problem hiding this comment.
Possibly, but we're never going to remember to do that when/if we delete branches. It may be better to just copy that sample into the docs instead of relying on it existing on GitHub.
Or, use a url shortener that produces a less-ugly URL.
There was a problem hiding this comment.
That would be on us to run broken link tests and not on you. If the target looks fine, I'll keep it as is. We're trying to avoid url shorteners as much as possible, since the community cannot edit them.
3 participants
Fixes #6509
@CESARDELATORRE FYI for an e-book PR
@davidfowl @natemcmaster can you please confirm that's the right URL? Thanks!