Skip to content

Encode string escape chars with code formatting #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2018
Merged

Encode string escape chars with code formatting #6261

merged 2 commits into from
Jul 2, 2018

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jul 2, 2018

This makes it a bit more clear how to use them.

@cartermp cartermp mentioned this pull request Jul 2, 2018
Merged
rpetrusha
rpetrusha approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @cartermp. You can merge when you're ready.

@cartermp cartermp merged commit fb0e4ab into master Jul 2, 2018
@cartermp cartermp deleted the cartermp-patch-1 branch July 2, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cartermp @rpetrusha