Skip to content

Removed mention of IAsync #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

Removed mention of IAsync #6187

merged 1 commit into from
Jul 5, 2018

Conversation

@rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jun 28, 2018 •
edited by JRAlexander
Loading

Removed mention of IAsync

This PR:

  • Removes mention of a limitation with the non-existent IAsync interface.
  • Replaces a token with its token text, which is .NET Native.

Fixes #6161

Internal Review URL
//cc @svick

Edited by: jralexander - 06/28/18 - Added Internal Review URL

@rpetrusha rpetrusha self-assigned this Jun 28, 2018
BillWagner
BillWagner approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

(Rich diff made the review much easier).

You can :shipit: when ready.

@rpetrusha rpetrusha merged commit 0a54811 into dotnet:master Jul 5, 2018
@rpetrusha rpetrusha deleted the net-native branch July 26, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels

None yet

Projects

None yet

Milestone

Sprint 137 (06/11/18 - 06/29/18)

Development

Successfully merging this pull request may close these issues.

2 participants

@rpetrusha @BillWagner