Remove a pointless mention of global.json #6150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document covers porting libraries from .NET Framework to .NET Core. The particular section is talking about features that are available in .NET Framework but missing in .NET Core. global.json is not such a feature. It is, in fact, new in .NET Core. This was actually introduced in PR #318 (commit 1a1b90f) as the .NET Core alternative to missing solution (.sln) files. At that point, .NET Core did not support solution files and project.json was the alternative, where users defined a list of projects. In other words, it made sense for this item - as an alternative - to be in a list of features not supported in .NET Core. This was changed in PR #2467 (commit 3877215) which updated this doc to take account of solution files. With solution files being supported, this is no longer a feature missing in .NET Core. In fact, it's incorrect for global.json to be in this list of ".NET Framework technologies [that are] unavailable in .NET Core".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document covers porting libraries from .NET Framework to .NET Core. The particular section is talking about features that are available in .NET Framework but missing in .NET Core. global.json is not such a feature. It is, in fact, new in .NET Core.
This was actually introduced in PR #318 (commit 1a1b90f) as the .NET Core alternative to missing solution (.sln) files. At that point, .NET Core did not support solution files and project.json was the alternative, where users defined a list of projects. In other words, it made sense for this item - as an alternative - to be in a list of features not supported in .NET Core.
This was changed in PR #2467 (commit 3877215) which updated this doc to take account of solution files. With solution files being supported, this is no longer a feature missing in .NET Core. In fact, it's incorrect for global.json to be in this list of ".NET Framework technologies [that are] unavailable in .NET Core".