Skip to content

Conversation

@v-maudel
Copy link
Contributor

@v-maudel v-maudel commented Jun 26, 2018

Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.

Hello, @mairaw ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well. I'll let @mairaw :shipit: when ready

@mairaw
Copy link
Contributor

mairaw commented Jun 26, 2018

@v-maudel this topic also presents other @ symbols. don't they also have to be escaped for loc?

@mairaw mairaw added the loc Indicates issues that are about localized content [org][type][category] label Jun 26, 2018
@mairaw mairaw added the waiting-on-feedback Waiting for feedback from SMEs before they can be merged label Jun 26, 2018
@v-maudel
Copy link
Contributor Author

Hi @mairaw ,
This was the only change reported by the production team, I think it is because the other @ characters that appears are well displayed because they are inside a link.
Although, I'm checking it with them.

regards.

@mairaw
Copy link
Contributor

mairaw commented Jun 27, 2018

I can accept as is and then you file a new PR if the other ones cause issues @v-maudel. Let me know!

@v-maudel
Copy link
Contributor Author

Hi @mairaw , I confirm that @ inside links doesn't affect the localization process.

@mairaw mairaw merged commit 9ed1110 into dotnet:master Jun 27, 2018
@v-maudel
Copy link
Contributor Author

Thanks @mairaw

@v-maudel v-maudel deleted the patch-4 branch June 27, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc Indicates issues that are about localized content [org][type][category] waiting-on-feedback Waiting for feedback from SMEs before they can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants