Skip to content

Conversation

@rpetrusha
Copy link
Contributor

Changed thread-local to partition-local

Fixes #5412

@stephentoub, I'm wondering if changing the description here from thread-local to partition-local is such a good idea, in part because it should really be done to the other Parallel.For and ForEach methods with local variables. What do you think?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a content perspective, this LGTM.

I'd also like @stephentoub 's opinion on these changes.

@mairaw mairaw requested a review from stephentoub June 26, 2018 18:55
@stephentoub
Copy link
Member

partition sounds fine to me. Arguably neither thread nor partition is 100% accurate, but being 100% accurate would entail implementation details that are subject to change. (In the current implementation, it's really a task-local value, where any number of tasks may be spun up by the implementation and which may run on that or a smaller number of threads and which may pull from any number of partitions of the input data.)

@rpetrusha rpetrusha merged commit 9ba0a96 into dotnet:master Jun 27, 2018
@rpetrusha rpetrusha deleted the partition-local branch July 26, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants