create migration to 2.1 topic #5967

mairaw · 2018-06-15T07:51:53Z

@leecow @richlander please let me know if this is what you had in mind for the migration topic.

Is there anything missing?
Do we need to state that they should also review package references and upgrade them if necessary to use a newer version?
Any API changes that should be called out? /cc @terrajobst
Do we have a similar topic for EF @divega? I'm already linking to the ASP.NET one.

pkulikov · 2018-06-15T10:56:45Z

docs/core/migration/20-21.md

@@ -0,0 +1,33 @@
+---
+title: Migrate from NET Core 2.0 to 2.1


Nit: missing dot in ".NET Core"

pkulikov · 2018-06-15T10:57:58Z

docs/core/migration/20-21.md

+ms.author: mairaw
+ms.date: 06/15/2018
+---
+# Migrate from NET Core 2.0 to 2.1


nit: missing dot in ".NET Core"

pkulikov · 2018-06-15T11:01:24Z

docs/core/migration/20-21.md

+---
+# Migrate from NET Core 2.0 to 2.1
+
+This article shows you how the basic steps for you to migrate your .NET Core 2.0 app to 2.1. If you're looking to migrate your ASP.NET Core application to 2.1, see [Migrate from ASP.NET Core 2.0 to 2.1](/aspnet/core/migration/20_21).


Please check the first sentence: "how" doesn't fit.

Good catch! I went back and forth on this one.

pkulikov · 2018-06-15T12:13:09Z

docs/core/migration/20-21.md

+
+For example, change `<TargetFramework>netcoreapp2.0</TargetFramework>` to `<TargetFramework>netcoreapp2.1</TargetFramework>`.
+
+* Remove `<DotNetCliToolReference>` references for tools that are bundled in the .NET Core 2.1 SDK. These references include:


Should the minimum SDK version (2.1.300) be mentioned?

pkulikov · 2018-06-15T12:15:34Z

docs/core/migration/20-21.md

+  * [dotnet-watch](https://github.com/aspnet/DotNetTools/blob/dev/src/dotnet-watch/README.md) (Microsoft.DotNet.Watcher.Tools)
+  * [dotnet-user-secrets](https://github.com/aspnet/DotNetTools/blob/dev/src/dotnet-user-secrets/README.md) (Microsoft.Extensions.SecretManager.Tools)
+  * [dotnet-sql-cache](https://github.com/aspnet/DotNetTools/blob/dev/src/dotnet-sql-cache/README.md) (Microsoft.Extensions.Caching.SqlConfig.Tools)
+  * [dotnet-dev-certs](https://github.com/aspnet/DotNetTools/blob/dev/src/dotnet-dev-certs/README.md) (?)


nit: there is a question mark at the end

yep, because I couldn't find how the reference to that was. 😄 I was hoping the reviewers would help me. @scottaddie do you know?

@mairaw What's the question?

I'm trying to add the exact references that need to be removed for each tool but I don't the one used for dotnet-dev-certs. also, can you check that the others are correct?

I believe dotnet-dev-certs is something completely new that doesn't replace any references in the .csproj file.

@natemcmaster See Maira's question above. Can you please provide a list of .csproj references to be removed?

Correct, dotnet-dev-certs never shipped as a DotNetCliToolRef. Here is a list of .csproj references that can be removed: aspnet/Announcements#290

Thanks @natemcmaster. The way it was written in the .NET Core 2.1 blog post announcement, made me think that it existed before:

The following existing DotNetCliReferenceTool tools have been converted to in-box tools.

dotnet watch
dotnet dev-certs
dotnet user-secrets
dotnet sql-cache
dotnet ef
Remove project references to these tools when you upgrade to .NET Core 2.1.

rpetrusha

Left a number of mostly minor comments, @mairaw. I thought I'd approve this, though it still needs review by the PU.

rpetrusha · 2018-06-15T14:51:29Z

docs/core/migration/20-21.md

+---
+# Migrate from NET Core 2.0 to 2.1
+
+This article shows you how the basic steps for you to migrate your .NET Core 2.0 app to 2.1. If you're looking to migrate your ASP.NET Core application to 2.1, see [Migrate from ASP.NET Core 2.0 to 2.1](/aspnet/core/migration/20_21).


nit: for you to migrate --> for migrating
nit: use of "app" in the first sentence, but "application" in the second; they should be consistent

rpetrusha · 2018-06-15T14:52:04Z

docs/core/migration/20-21.md

+
+* Open the project file (the \*.csproj, \*.vbproj, or \*.fsproj file).
+
+* Change the [target framework](../../standard/frameworks.md) value from `netcoreapp2.0` to `netcoreapp2.1`. The target framework is defined on the `<TargetFramework>` or `<TargetFrameworks>` element.


rpetrusha · 2018-06-15T14:53:42Z

docs/core/migration/20-21.md

+
+For example, change `<TargetFramework>netcoreapp2.0</TargetFramework>` to `<TargetFramework>netcoreapp2.1</TargetFramework>`.
+
+* Remove `<DotNetCliToolReference>` references for tools that are bundled in the .NET Core 2.1 SDK. These references include:


I think that it might be useful to explain why tools references can be removed.

leecow

Looks good. Thanks.

create migration to 2.1 topic

399881d

mairaw added P0 labels Jun 15, 2018

mairaw added this to the Sprint 137 (06/11/18 - 06/29/18) milestone Jun 15, 2018

mairaw self-assigned this Jun 15, 2018

mairaw requested review from leecow and richlander June 15, 2018 07:51

pkulikov reviewed Jun 15, 2018

View reviewed changes

rpetrusha approved these changes Jun 15, 2018

View reviewed changes

feedback

57a3fa0

leecow approved these changes Jun 18, 2018

View reviewed changes

feedback

fb71264

mairaw added verify-build-before-merge and removed verify-build-before-merge labels Jun 18, 2018

mairaw merged commit c0c8625 into dotnet:master Jun 18, 2018

mairaw deleted the migrate21 branch June 18, 2018 18:48

BillWagner added dotnet-core/prod and removed 📚 Area - .NET Core Guide labels Feb 10, 2021


		For example, change `<TargetFramework>netcoreapp2.0</TargetFramework>` to `<TargetFramework>netcoreapp2.1</TargetFramework>`.

		* Remove `<DotNetCliToolReference>` references for tools that are bundled in the .NET Core 2.1 SDK. These references include:


		* Open the project file (the \.csproj, \.vbproj, or \*.fsproj file).

		* Change the [target framework](../../standard/frameworks.md) value from `netcoreapp2.0` to `netcoreapp2.1`. The target framework is defined on the `<TargetFramework>` or `<TargetFrameworks>` element.

create migration to 2.1 topic #5967

create migration to 2.1 topic #5967

Uh oh!

Conversation

mairaw commented Jun 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natemcmaster Jun 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpetrusha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leecow left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

natemcmaster Jun 18, 2018 •

edited

Loading