Skip to content

Conversation

@tsahi
Copy link
Contributor

@tsahi tsahi commented Jun 11, 2018

Summary

Use C# 6 features and other improvements

Fixes #5903

tsahi added 2 commits June 11, 2018 23:40
Use C# 6 null-propagation operator to check for event handlers.
Use C# 6 null-propagation operator; use `EventArgs.Empty` instead of `new EventArgs()`; no need for `new EventHandler()`, the compiler will do it for you.
@tsahi tsahi requested a review from BillWagner as a code owner June 11, 2018 20:56
@dnfclas
Copy link

dnfclas commented Jun 11, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it @tsahi We appreciate it. I've reviewed the changes and I'll :shipit: now.

You should see the changes on the live site on our regular publish cycle. Thanks again.

@BillWagner BillWagner merged commit 6cd2a0b into dotnet:master Jun 12, 2018
@tsahi tsahi deleted the patch-1 branch June 13, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants