Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 8, 2018

Replaces PR #5426


Thank you for your interest in contributing to the .NET documentation!

> We're in the process of moving our guidelines into a site-wide contribution guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should't be better to use >>> instead of > for each line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would that help? I think that triple blockquote looks worse and doesn't make sense.

Compare:

We're in the process of moving our guidelines into a site-wide contribution guide.

With:

We're in the process of moving our guidelines into a site-wide contribution guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad. I was confusing the markdown operator > here on GitHub with the >>> from Slack when we have multiples lines.

Copy link
Contributor

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can :shipit: when ready

@mairaw mairaw merged commit 2dce3b2 into master Jun 11, 2018
@mairaw mairaw deleted the mairaw-patch-3 branch June 11, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants