Updated microservice tutorial #5878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkulikov Thanks, I didn't know about that issue. Yeah, I think this PR should cover that issue too, I have added it to the "fixes" list. |
rpetrusha
added
the
🚧 Hold for related PR
|
Closing and reopening to begin new build. |
|
I see that the companion PR was merged and I was planning to push the samples live now, but I won't do that until this is merged. When we merge companion PRs, we should be ready to merge both as soon as builds pass. |
|
@mairaw If it helps, feel free to revert that PR and I can recreate it. |
|
Don't worry @svick. There weren't any high-pri changes to push so we can wait until next week. |
BillWagner
approved these changes
Jun 11, 2018
There was a problem hiding this comment.
This is a really good set of changes @svick
I'll 
now.
Thanks for all your contributions to docs.
mairaw
removed
the
🚧 Hold for related PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5700.
Fixes dotnet/core#1669.
Fixes #2648.
Companion PR that updates samples: dotnet/samples#114.