Skip to content

Conversation

@vnextcoder
Copy link
Contributor

Fix Lifted Conversions Link

Summary

Describe your changes here. Fix the Lifted Conversions link

Fixes #Issue_Number (if available) - none

Fix Lifted Conversions Link
@vnextcoder vnextcoder requested a review from BillWagner as a code owner June 7, 2018 18:05
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vnextcoder! Your PR fixes the issue but the link wasn't following our guidelines for internal links. Can you make the change I suggested?

[!code-csharp[TupleEquality](../../samples/snippets/csharp/tuples/tuples/program.cs#Equality "Testing tuples for equality")]

There are several rules that make tuple equality tests more convenient. Tuple equality performs [lifted conversions](/dotnet/csharp/language-reference/language-specification/conversions.md#lifted-conversion-operators) if one of the tuples is a nullable tuple, as shown in the following code:
There are several rules that make tuple equality tests more convenient. Tuple equality performs [lifted conversions](/dotnet/csharp/language-reference/language-specification/conversions#lifted-conversion-operators) if one of the tuples is a nullable tuple, as shown in the following code:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does fix the broken link but would you be so kind to change this to a relative url so the link gets validated during our build process?

/dotnet/csharp/language-reference/language-specification/conversions#lifted-conversion-operators -> ./language-reference/language-specification/conversions.md#lifted-conversion-operators

@mairaw mairaw added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Jun 7, 2018
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my apologies. Your fix was correct. I forgot that link to the content outside our repo. Thank you @vnextcoder!

@mairaw mairaw merged commit f01d5f1 into dotnet:master Jun 12, 2018
@vnextcoder
Copy link
Contributor Author

Sorry @mairaw , I couldn't see your messages earlier. I hope all fine with the PR and change I suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet-csharp/svc ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants