API name change #5845
Merged
API name change #5845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API that was called `DangerousGetPinnableReference` was changed just before release. It is now `GetPinnableReference`. Fixes #5767
|
The OPS build succeeded using the new API. |
mairaw
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
LGTM. But this is interesting. We should follow up with @TianqiZhang and @herohua. I’d expect to get warnings here after I’ve updated the reference for 2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API that was called
DangerousGetPinnableReferencewas changed just before release. It is nowGetPinnableReference.Fixes #5767
cc /@jskeet @jcouv
Note: If the OPS build fails, that indicates we need to update the API reference for Span and other types that support the pattern.
Internal review links: