Skip to content

Conversation

@rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jun 5, 2018

Modified Standard numeric format strings topic

This PR makes two changes:

  • Removes the statement that "R" does not successfully round-trip with Single.
  • Makes C# examples interactive.

Internal review URL

Fixes #5402

@mairaw, @davidmatson

@davidmatson
Copy link

Should we still recommend the use of G9 with Single, if R is just as good? (R is simpler, right?)

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left some comments. Do you want to have someone to validate the technical aspect of this change or not needed?

### Floating-Point Infinities and NaN
Regardless of the format string, if the value of a <xref:System.Single> or <xref:System.Double> floating-point type is positive infinity, negative infinity, or not a number (NaN), the formatted string is the value of the respective <xref:System.Globalization.NumberFormatInfo.PositiveInfinitySymbol%2A>, <xref:System.Globalization.NumberFormatInfo.NegativeInfinitySymbol%2A>, or <xref:System.Globalization.NumberFormatInfo.NaNSymbol%2A> property that is specified by the currently applicable <xref:System.Globalization.NumberFormatInfo> object.

<a name="example"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this line

---
# Standard Numeric Format Strings

[!INCLUDE[interactive-note](~/includes/csharp-interactive-note.md)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this as the first thing in the topic might hurt SEO. Maybe move this to where the samples start?
Also, should the note discuss culture as well? Things like this could confuse people (where text, snippet and interactive don't match):
image

@rpetrusha rpetrusha merged commit d6fa1ed into dotnet:master Jun 11, 2018
@rpetrusha rpetrusha deleted the std-numeric branch June 11, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants