Skip to content

Conversation

@florinciubotariu
Copy link
Contributor

Relates to #3391 and #3426.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @florinciubotariu, for continuing to replace FWLinks. I have two requests for changes -- it's best not to include the version selector in the URL.

Provides links to topics that help you learn about the basics of Visual Studio.

[.NET Framework Class Library](http://go.microsoft.com/fwlink/?LinkID=227195)
[.NET Framework Class Library](/dotnet/api/?view=netframework-4.7.2)
Copy link
Contributor

@rpetrusha rpetrusha Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best here not to include the version filter (?view=netframework-4.7.2), or this will have to be updated for each .NET Framework release, a detail that's certain to be overlooked. The description should also read ".NET API Browser".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, in other similar cases, the link text was changed to ".NET API Browser":

[.NET API Browser](/dotnet/api)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry about omitting that detail, @florinciubotariu, and thanks for pointing it out, @pkulikov. I'll revise my previous comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, given that the page is in our repo, you could probably use a relative path to https://github.com/dotnet/docs/blob/master/api/index.md

Provides links to sample applications that demonstrate .NET Framework technologies.

[.NET Framework Class Library](http://go.microsoft.com/fwlink/?LinkID=227195)
[.NET Framework Class Library](/dotnet/api/?view=netframework-4.7.2)
Copy link
Contributor

@rpetrusha rpetrusha Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again, this is best without the version filter, and the link text should read, ".NET API Browser".

@florinciubotariu
Copy link
Contributor Author

florinciubotariu commented Jun 5, 2018

Thank you, everyone, for your suggestions.
Learnt some new things :)

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @florinciubotariu, for making the additional corrections. I'll merge your PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants