-
Notifications
You must be signed in to change notification settings - Fork 6.1k
FwLinks replacement in visual-basic-folder (5) #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FwLinks replacement in visual-basic-folder (5) #5799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @florinciubotariu, for continuing to replace FWLinks. I have two requests for changes -- it's best not to include the version selector in the URL.
docs/visual-basic/index.md
Outdated
| Provides links to topics that help you learn about the basics of Visual Studio. | ||
|
|
||
| [.NET Framework Class Library](http://go.microsoft.com/fwlink/?LinkID=227195) | ||
| [.NET Framework Class Library](/dotnet/api/?view=netframework-4.7.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best here not to include the version filter (?view=netframework-4.7.2), or this will have to be updated for each .NET Framework release, a detail that's certain to be overlooked. The description should also read ".NET API Browser".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember, in other similar cases, the link text was changed to ".NET API Browser":
[.NET API Browser](/dotnet/api)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry about omitting that detail, @florinciubotariu, and thanks for pointing it out, @pkulikov. I'll revise my previous comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, given that the page is in our repo, you could probably use a relative path to https://github.com/dotnet/docs/blob/master/api/index.md
| Provides links to sample applications that demonstrate .NET Framework technologies. | ||
|
|
||
| [.NET Framework Class Library](http://go.microsoft.com/fwlink/?LinkID=227195) | ||
| [.NET Framework Class Library](/dotnet/api/?view=netframework-4.7.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here again, this is best without the version filter, and the link text should read, ".NET API Browser".
|
Thank you, everyone, for your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @florinciubotariu, for making the additional corrections. I'll merge your PR now.
Relates to #3391 and #3426.