Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jun 1, 2018

Fixes a few things from #5744 and moves some naming and whitespace guidelines up near the top.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I had a couple suggestions, if you want to adopt them.

:shipit: when you are ready.

Classes, interfaces, structs, enumerations, delegates, records, and discriminated unions should all be named with PascalCase. Members within types and labels for records and discriminated unions should also use PascalCase.

```fsharp
type IMyInterface =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to recommend that interfaces start with I?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We follow .NET naming guidelines here.

```fsharp
x |> f // Forward pipeline
f >> g // Forward composition
x |> ignore // Throwing away a value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider "discard a value" to avoid similarity to throw

@cartermp cartermp merged commit 72b140b into master Jun 7, 2018
@mairaw mairaw deleted the formatting-fixes branch June 20, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants