Updated do and while keyword topics #5650
Merged
+56
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
added
the
🚧 Hold for related PR
|
closing and reopening to start a new build. dotnet/samples#86 has been merged. |
BillWagner
requested changes
May 29, 2018
There was a problem hiding this comment.
This is a really nice improvement @pkulikov
I had a couple very small nits to address before we 
Thanks again for all the contributions. We appreciate it.
|
|
||
| ## Example | ||
|
|
||
| The following example shows the usage of the `do` statement. Select the **Run** to run the example code. After that you can modify the code and run it again. |
There was a problem hiding this comment.
nit: "Select Run" instead of "Select the Run"
|
|
||
| ## Example | ||
|
|
||
| The following example shows the usage of the `while` statement. Select the **Run** to run the example code. After that you can modify the code and run it again. |
There was a problem hiding this comment.
nit: "Select Run" instead of "Select the Run"
|
@BillWagner thank you for the review; I've fixed both nits. |
BillWagner
approved these changes
May 29, 2018
|
Thanks @pkulikov I'll |
mairaw
removed
the
🚧 Hold for related PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During PR #5597, I've thought why not to unify all iteration keywords topics. This PR update while and do topics:
whileloop examples. In the current edition, those examples serve not the while loop, but the evaluation of the increment operator, which is off-topic, I would say.falseto ...while a specified boolean expression evaluates totrue, which might be easier to grasp.Depends on dotnet/samples#86