Skip to content

Conversation

@robertmuehsig
Copy link
Contributor

Summary

The version namings and version numbers of Windows 10 is not really descriptive, because on some sites (e.g. the lifecycle description page ) the version number is used. The get a better sense what is included or not I added the version number.

Sorry for the huge "diff" - I just added the version numbers in ( ) behind the windows versions.

The version namings and version numbers of Windows 10 is not really descriptive, because on some sites (e.g. the [lifecycle description](https://support.microsoft.com/de-ch/help/13853/windows-lifecycle-fact-sheet) page ) the version number is used. The get a better sense what is included or not I added the version number.
@robertmuehsig robertmuehsig requested a review from rpetrusha as a code owner May 28, 2018 10:20
@JRAlexander JRAlexander added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label May 29, 2018
@aaronfranke
Copy link
Contributor

aaronfranke commented May 29, 2018

It may be worthwhile changing this to "10 (1607 to 1709)" instead, as it would be much less text.

On a related note, the sizing of the columns really needs improvement. The title for the
"✓ Included in + Can be installed on Windows Server" column takes up 8 lines.

@svick
Copy link
Contributor

svick commented May 30, 2018

@aaronfranke

On a related note, the sizing of the columns really needs improvement.

I have opened an issue about the appearance of that table: #5646.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the dotnet/docs repo and adding version numbers, @robertmuehsig. For clarity, could you add "Version" before the version numbers? If you'd like, we can make this change for you.

The overall formatting of this topic is problematic. We'll address it in our next scheduled sprint, which begins on Monday, June 11.

@robertmuehsig
Copy link
Contributor Author

Yeah - the formatting is quite bad, but I added "version" in front of the number.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @robertmuehsig, for making the additional changes. We'll merge your PR now. Changes should appear live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 4b36aba into dotnet:master Jun 12, 2018
@robertmuehsig robertmuehsig deleted the patch-1 branch June 12, 2018 16:50
@robertmuehsig
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants