Skip to content

Correct SYSLIB1219 source generator overview - #56346

Merged
ViveliDuCh merged 1 commit into
mainfrom
fix-syslib1219-overview
Oct 9, 2026
Merged

ViveliDuCh merged 1 commit into
mainfrom
fix-syslib1219-overview

Conversation

@ViveliDuCh

@ViveliDuCh ViveliDuCh commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Fixes #56285.

Corrects the stale SYSLIB1219 reserved entry in the consolidated source-generator overview to document the ValidateAsync diagnostic added in #56288.

SYSLIB1218 remains intentionally reserved: the runtime registry reserves it for Microsoft.Extensions.Options.SourceGeneration, and the Options generator defines no corresponding diagnostic descriptor.


Internal previews

File Preview link
docs/fundamentals/syslib-diagnostics/source-generator-overview.md Learn preview

Build report

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bce396c4-2142-4037-a7bb-f463dfa57896
@ViveliDuCh
ViveliDuCh requested a review from a team as a code owner October 8, 2026 19:34
Copilot AI balanced review requested due to automatic review settings October 8, 2026 19:34
@dotnetrepoman dotnetrepoman Bot added this to the October 2026 milestone Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The description matches the runtime diagnostic and the consolidated reference page.

0 open findings

What changed in this PR

Updates the source-generator diagnostic index to accurately describe SYSLIB1219.

Changes:

  • Replaces the stale reserved placeholder with the ValidateAsync diagnostic description.
File Description
source-generator-overview.md Documents the purpose of SYSLIB1219.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@ViveliDuCh
ViveliDuCh requested a review from gewarren October 8, 2026 20:33
@ViveliDuCh
ViveliDuCh merged commit 47c4214 into main Oct 9, 2026
14 checks passed
@ViveliDuCh
ViveliDuCh deleted the fix-syslib1219-overview branch October 9, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SYSLIB1219 (and placeholder SYSLIB1218) missing from the options-validation source-generator diagnostics reference

3 participants