Repository navigation
Fix the CA1864 title to reference Dictionary.TryAdd - #56327
Open
AsadIqbal-Dev wants to merge 1 commit into
Open
AsadIqbal-Dev wants to merge 1 commit into
AsadIqbal-Dev wants to merge 1 commit into
Conversation
IDictionary<TKey,TValue> doesn't define a TryAdd method. The rule applies to types that have their own TryAdd method, such as Dictionary<TKey,TValue>. Also fix "It's is" in the rule list entries.
dotnet-policy-service
Bot
added
dotnet-fundamentals/svc
community-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CA1864 title referred to
IDictionary.TryAdd(TKey, TValue), butIDictionary<TKey,TValue>doesn't define aTryAddmethod. The rule applies to types that have their ownTryAddmethod, such asDictionary<TKey,TValue>, and the rest of the page already links toDictionary<TKey,TValue>.TryAdd.This updates the title on the rule page and in the rule lists (
index.mdandperformance-warnings.md), and fixes "It's is more efficient" in the same table rows.The analyzer's own title is being fixed in dotnet/sdk#56511 (reported in dotnet/sdk#51141, where this docs page was also mentioned).
Internal previews
Build report