L21207: Code box creating inconsistency #5556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, @mairaw, Localization team has reported source content issue that causes localized version to have broken format compared to en-us version. Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR. Many thanks in advance.
svick
reviewed
May 23, 2018
| - The xref:System.ServiceModel.Channels.ChannelFactoryBase class implements xref:System.ServiceModel.Channels.ChannelManagerBase and xref:System.ServiceModel.Channels.IChannelFactory and consolidates the CreateChannel overloads into one `OnCreateChannel` abstract method. | ||
|
|
||
| - The``<xref:System.ServiceModel.Channels.ChannelListenerBase> class implements <xref:System.ServiceModel.Channels.IChannelListener>. It takes care of basic state management. | ||
| - The xref:System.ServiceModel.Channels.ChannelListenerBase class implements xref:System.ServiceModel.Channels.IChannelListener. It takes care of basic state management. |
There was a problem hiding this comment.
I think the right fix here is to remove the ``, but keep the angle brackets as they are. Otherwise the xrefs won't work.
There was a problem hiding this comment.
That's correct. The double `` should be removed, but the < and > should stay.
BillWagner
requested changes
May 23, 2018
it.| - The xref:System.ServiceModel.Channels.ChannelFactoryBase class implements xref:System.ServiceModel.Channels.ChannelManagerBase and xref:System.ServiceModel.Channels.IChannelFactory and consolidates the CreateChannel overloads into one `OnCreateChannel` abstract method. | ||
|
|
||
| - The``<xref:System.ServiceModel.Channels.ChannelListenerBase> class implements <xref:System.ServiceModel.Channels.IChannelListener>. It takes care of basic state management. | ||
| - The xref:System.ServiceModel.Channels.ChannelListenerBase class implements xref:System.ServiceModel.Channels.IChannelListener. It takes care of basic state management. |
There was a problem hiding this comment.
That's correct. The double `` should be removed, but the < and > should stay.
|
Hello, @BillWagner and @svick, |
BillWagner
approved these changes
May 24, 2018
|
Thanks for making the updates @carolinacmoravia I've reviewed the updates and I'll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @mairaw,
Localization team has reported source content issue that causes localized version to have broken format compared to en-us version.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)