Skip to content

Conversation

@gosali
Copy link

@gosali gosali commented May 21, 2018

Hello, @maira,
This proposed file change comes from https://github.com/dotnet/docs.ru-ru/pull/75/files?utf8=%E2%9C%93&diff=split&w=1 .
Line #98

Could you review this contribution and help to merge if agreed?
Many thanks in advance.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Hello, @maira,
This proposed file change comes from https://github.com/dotnet/docs.ru-ru/pull/75/files?utf8=%E2%9C%93&diff=split&w=1 . 
Line dotnet#98

Could you review this contribution and help to merge if agreed?
Many thanks in advance.
@gosali gosali requested a review from mairaw as a code owner May 21, 2018 20:38
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the location, you also have to change the preceding text. Instead of image above on line 96, it should be following image @gosali.

@gosali
Copy link
Author

gosali commented May 22, 2018

@mairaw Thank you a lot for your reply. But I'm confused, Should I makefurther changes?
@carolinacmoravia
BR

@mairaw
Copy link
Contributor

mairaw commented May 22, 2018

@gosali we can't accept this as-is. So please change the following sentence:
"You can see this relationship in the image above." to
"You can see this relationship in the following image."

You just have to click the pencil on the files view:
image

@carolinacmoravia
Copy link
Contributor

Hello, @gosali,
You'll need to make a new commit with the change requested by @mairaw.
Thanks in advance for your support. :)

@gosali
Copy link
Author

gosali commented May 23, 2018

@mairaw Please see the last commit and help to merge.
Thank you a lot!

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes @gosali.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants