Skip to content

Conversation

@pkulikov
Copy link
Contributor

No description provided.

@pkulikov pkulikov requested a review from BillWagner as a code owner May 20, 2018 14:09
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkulikov, for updating this topic. Your changes look good -- except would you mind updating the date in the topic's metadata as well? Especially because what was once a promised feature is now a real feature, your change definitely warrants it.

@pkulikov
Copy link
Contributor Author

@rpetrusha thank you for the catch: date is updated.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this after @rpetrusha's comments and @pkulikov 's update. We can :shipit: now.

@rpetrusha rpetrusha merged commit 9f43216 into dotnet:master May 21, 2018
@pkulikov pkulikov deleted the patch-2 branch May 21, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants