Skip to content

Add accessibility modifier info to interfaces #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

Add accessibility modifier info to interfaces #5279

merged 1 commit into from
May 11, 2018

Conversation

@cartermp
Copy link
Contributor

Addresses #5261

@cartermp
Update interfaces.md
61471dd 
Add accessibility modifier info
rpetrusha
rpetrusha approved these changes May 10, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @cartermp. Do you want to include a list of the valid accessibility modifiers?

@cartermp
Copy link
Contributor Author

@rpetrusha Nope, I think it's fine as-is. Everything else is formatted this way.

@cartermp cartermp merged commit 07f7c86 into master May 11, 2018
@mairaw mairaw deleted the cartermp-patch-1 branch May 11, 2018 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cartermp @rpetrusha