core metadata updates - round 2 #5140
Conversation
| ms.date: 06/20/2016 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
You kept this ms.technology.
There was a problem hiding this comment.
Same reason. Not under tools where I set the ms.technology globally.
| ms.date: 08/30/2017 | ||
| ms.topic: conceptual | ||
| dev_langs: | ||
| - "fsharp" |
There was a problem hiding this comment.
Left this dev_langs for F#. but the next file you remove it
There was a problem hiding this comment.
I didn't touch (or not supposed to touch) any of dev_langs.
| ms.workload: | ||
| - dotnetcore | ||
| dev_langs: | ||
| - "fsharp" |
There was a problem hiding this comment.
I just removed ms.topic and the values below dev_langs. It's just the diff that is not aligning these correctly @JRAlexander.
| ms.date: 09/01/2017 | ||
| ms.topic: conceptual | ||
| dev_langs: | ||
| - "vb" |
| ms.date: 09/01/2017 | ||
| ms.topic: conceptual | ||
| dev_langs: | ||
| - "vb" |
There was a problem hiding this comment.
The dev_langs are kept in this one, too.
| ms.workload: | ||
| - dotnetcore | ||
| dev_langs: | ||
| - "vb" |
There was a problem hiding this comment.
But removed and readded here
| ms.date: 08/11/2017 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
ms.technology removed here
There was a problem hiding this comment.
yes, if you see on preview, this file should have the value coming from the global setting.
| ms.prod: dotnet-core | ||
| ms.technology: devlang-vb | ||
| dev_langs: | ||
| - "vb" |
| ms.prod: dotnet-core | ||
| ms.technology: devlang-vb | ||
| dev_langs: | ||
| - "vb" |
| ms.date: 03/08/2017 | ||
| ms.topic: get-started-article | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
| ms.date: 06/20/2016 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
Yes, they are not on the global settings so I left them. @rpetrusha do you think these should continue to be tagged as CLI?
There was a problem hiding this comment.
Generally LGTM, @JMAlexander left a number of comments, and I left one.
docs/core/additional-tools/index.md
Outdated
| title: .NET Core additional tools | ||
| description: An overview of the additional tools that support and extend .NET Core functionality. | ||
| author: mlacouture | ||
| manager: wpickett |
There was a problem hiding this comment.
nit: This and the next file include manager metadata, as do some later files.
There was a problem hiding this comment.
Good catch @rpetrusha!
There was a problem hiding this comment.
@JRAlexander I think I've addressed all your questions, but please let me know if there's something still not clear. Thanks!
| ms.date: 06/20/2016 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
Yes, they are not on the global settings so I left them. @rpetrusha do you think these should continue to be tagged as CLI?
docs/core/additional-tools/index.md
Outdated
| title: .NET Core additional tools | ||
| description: An overview of the additional tools that support and extend .NET Core functionality. | ||
| author: mlacouture | ||
| manager: wpickett |
There was a problem hiding this comment.
Good catch @rpetrusha!
| ms.date: 06/20/2016 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
Same reason. Not under tools where I set the ms.technology globally.
| ms.workload: | ||
| - dotnetcore | ||
| dev_langs: | ||
| - "fsharp" |
There was a problem hiding this comment.
I just removed ms.topic and the values below dev_langs. It's just the diff that is not aligning these correctly @JRAlexander.
| ms.date: 08/30/2017 | ||
| ms.topic: conceptual | ||
| dev_langs: | ||
| - "fsharp" |
There was a problem hiding this comment.
I didn't touch (or not supposed to touch) any of dev_langs.
| ms.date: 08/11/2017 | ||
| ms.topic: conceptual | ||
| ms.prod: dotnet-core | ||
| ms.technology: dotnet-cli |
There was a problem hiding this comment.
yes, if you see on preview, this file should have the value coming from the global setting.
3 participants
I've moved more metadata to the global settings so making round 2 for the core folder
Related to #5062