Skip to content

framework metadata updates - part 7 #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2018
Merged

framework metadata updates - part 7 #5131

merged 2 commits into from
May 3, 2018

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented May 3, 2018

Related to #5062

@mairaw mairaw added this to the Sprint 135 (4/28/18 - 5/18/18) milestone May 3, 2018
@mairaw mairaw self-assigned this May 3, 2018
@mairaw mairaw requested a review from rpetrusha as a code owner May 3, 2018 04:53
rpetrusha
rpetrusha approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've only spot-checked, but this looks consistent. You can merge when you're ready.

@mairaw mairaw merged commit 78c12ce into dotnet:master May 3, 2018
@mairaw mairaw deleted the metadata-framework-7 branch May 3, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mairaw mairaw

Labels

None yet

Projects

None yet

Milestone

Sprint 135 (4/28/18 - 5/18/18)

Development

Successfully merging this pull request may close these issues.

2 participants

@mairaw @rpetrusha