Replace Visual Studio token with plain text #5037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErlendLandro
requested review from
BillWagner,
douglaslMS and
rpetrusha
as code owners
BillWagner
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
Thanks again @Mackiovello I could review this in the GitHub UI, so it wasn't too big.
Everything looks good to me. I'll let @rpetrusha merge this, and check the other repos for the same include.
|
Thanks for submitting this PR, @Mackiovello. I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4801
I'm not sure if this is too big for one PR. This is the RegEx I used for it:
It's not perfect, but so far, it seems accurate.