Skip to content

Conversation

@BillWagner
Copy link
Member

Reviewed the following files:

  • Readme.md updated to mention samples and dotnet-api-docs repositories.
  • .Contributing.md: pointed to samples and dotnet-api-docs repos as appropriate.
  • .github folder: removed samples directories from CodeOwners.md

Taken from #4846 (I was mistakenly working on my master branch)

Reviewed the following files:

- [x] Readme.md
- [x] Contributing.md was created and points to the docs repo.
- [x] Code_of_conduct.md was created and follows the docs repo.
- [x] .gitignore Created for samples and projects.
- [x] .github folder: created pull request template and codeowners file based on docs repository.
See comments on #4846
@BillWagner BillWagner mentioned this pull request Apr 1, 2018
3 tasks
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but had a question about how we list the different repos

CONTRIBUTING.md Outdated
* [Building the docs](#building-the-docs)
* [Contributor License Agreement](#contributor-license-agreement)

This repository contains the conceptual documentation for .NET. There are separate repositories for the [code samples and snippets](https://github.com/dotnet/samples) and [API reference](https://github.com/dotnet/dotnet-api-docs). Issues and tasks for all three of those repositories are tracked here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a list instead of all the docs repos? We also have the roslyn-api-docs too. Are we tracking the work for that one here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Roslyn-api-docs repo both here and in the readme.

Also, add the roslyn-api-docs.
@BillWagner BillWagner merged commit ac51376 into dotnet:master Apr 3, 2018
@BillWagner BillWagner deleted the update-readme-for-split branch April 3, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants