-
Notifications
You must be signed in to change notification settings - Fork 6k
Add docs for SYSLIB5003 #43288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for SYSLIB5003 #43288
Conversation
docs/fundamentals/syslib-diagnostics/source-generator-overview.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also add a link from the experimental-overview.md file?
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 changes left for reverting files that didn't need updates, but then approved.
Thank you!
docs/fundamentals/syslib-diagnostics/source-generator-overview.md
Outdated
Show resolved
Hide resolved
I overlooked this. The experimental-overview page should link to this one per @gewarren's suggestion. The table's first cell that has the diagnostic ID can just become a link to this page; that should be sufficient. |
done |
Summary
Describe your changes here.
Contributes to #42812
Internal previews