Skip to content

Add docs for SYSLIB5003 #43288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Add docs for SYSLIB5003 #43288

merged 11 commits into from
Nov 12, 2024

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Nov 1, 2024

kunalspathak and others added 5 commits November 1, 2024 15:40
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also add a link from the experimental-overview.md file?

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@kunalspathak
Copy link
Member Author

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 changes left for reverting files that didn't need updates, but then approved.

Thank you!

@jeffhandley
Copy link
Member

Shouldn't we also add a link from the experimental-overview.md file?

https://github.com/dotnet/docs/blob/main/docs/fundamentals/syslib-diagnostics/experimental-overview.md already has a reference, unless you want me to add something more.

I overlooked this. The experimental-overview page should link to this one per @gewarren's suggestion. The table's first cell that has the diagnostic ID can just become a link to this page; that should be sufficient.

@kunalspathak
Copy link
Member Author

done

@gewarren gewarren enabled auto-merge (squash) November 8, 2024 23:00
@gewarren gewarren merged commit b097bb5 into dotnet:main Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants