Skip to content

ZipArchiveEntry encoding breaking change #42475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2024
Merged

ZipArchiveEntry encoding breaking change #42475

merged 2 commits into from
Sep 6, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 4, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner September 4, 2024 22:14
@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 4, 2024
BillWagner
BillWagner reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM once @carlossanlop agrees.

@gewarren gewarren merged commit 83b0e0f into dotnet:main Sep 6, 2024
8 checks passed
@gewarren gewarren deleted the ziparchiveentry branch September 6, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner left review comments

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.

[Breaking change]: ZipArchiveEntry names and comments now respect UTF8 flag when decoded
4 participants
@gewarren @BillWagner @carlossanlop @dotnet-bot