-
Notifications
You must be signed in to change notification settings - Fork 6k
Add preferreduilang to F# compiler options and FSI options table #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM. I'll close and reopen to trigger a new build as the OPS build seems stuck.
Once the build is clean, I'll
Hang on - I'll add this to F# Interactive as well |
there are some merge conflicts on the PR @cartermp |
@@ -53,6 +53,7 @@ The following table shows compiler options listed alphabetically. Some of the F# | |||
|**--out:<output-filename>**<br /><br />**-o:<output-filename>**|Specifies the name of the compiled assembly or module.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/out (C# Compiler Options)](https://msdn.microsoft.com/library/bw3t50f3.aspx).| | |||
|**--pdb:<pdb-filename>**|Names the output debug PDB (program database) file. This option only applies when **--debug** is also enabled.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/pdb (C# Compiler Options)](https://msdn.microsoft.com/library/ms228625.aspx).| | |||
|**--platform:<platform-name>**|Specifies that the generated code will only run on the specified platform (**x86**, **Itanium**, or **x64**), or, if the platform-name **anycpu** is chosen, specifies that the generated code can run on any platform.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/platform (C# Compiler Options)](https://msdn.microsoft.com/library/zekwfyz4.aspx).| | |||
|**--preferreduilang:<lang>**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. -> for example,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits to be fixed
@@ -52,6 +52,7 @@ Where lists appear in F# Interactive option arguments, list elements are separat | |||
|**--nologo**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | |||
|**--nowarn:<warning-list>**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | |||
|**--optimize**[**+**|**-**]|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | |||
|**--preferreduilang:<lang>**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -94,5 +94,5 @@ test | |||
|
|||
|Title|Description| | |||
|-----|-----------| | |||
|[F# Interactive Options](fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.| | |||
|[F# Interactive Options](../../language-reference/fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command line -> command-line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You can merge it when build finishes
🎉 |
öööf that build is taking a while |
The webhook seems to be failing for this PR. Not sure why. I can open a LSI in the morning if the issue persists. |
Build still hung. Closing and reopening. |
Submitted LSI. |
Fixes #4183
Also moves the FSI options table to the language reference, since that's a better place based on the fact that the compiler options table is there, too.