Skip to content

Add preferreduilang to F# compiler options and FSI options table #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Add preferreduilang to F# compiler options and FSI options table #4193

merged 3 commits into from
Jan 29, 2018

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 24, 2018

Fixes #4183

Also moves the FSI options table to the language reference, since that's a better place based on the fact that the compiler options table is there, too.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. I'll close and reopen to trigger a new build as the OPS build seems stuck.

Once the build is clean, I'll :shipit:

@BillWagner BillWagner closed this Jan 24, 2018
@BillWagner BillWagner reopened this Jan 24, 2018
@cartermp
Copy link
Contributor Author

Hang on - I'll add this to F# Interactive as well

@cartermp cartermp changed the title Add preferreduilang to F# compiler options table Add preferreduilang to F# compiler options and FSI options table Jan 24, 2018
@mairaw
Copy link
Contributor

mairaw commented Jan 24, 2018

there are some merge conflicts on the PR @cartermp

@@ -53,6 +53,7 @@ The following table shows compiler options listed alphabetically. Some of the F#
|**--out:&lt;output-filename&gt;**<br /><br />**-o:&lt;output-filename&gt;**|Specifies the name of the compiled assembly or module.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [&#47;out &#40;C&#35; Compiler Options&#41;](https://msdn.microsoft.com/library/bw3t50f3.aspx).|
|**--pdb:&lt;pdb-filename&gt;**|Names the output debug PDB (program database) file. This option only applies when **--debug** is also enabled.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [&#47;pdb &#40;C&#35; Compiler Options&#41;](https://msdn.microsoft.com/library/ms228625.aspx).|
|**--platform:&lt;platform-name&gt;**|Specifies that the generated code will only run on the specified platform (**x86**, **Itanium**, or **x64**), or, if the platform-name **anycpu** is chosen, specifies that the generated code can run on any platform.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [&#47;platform &#40;C&#35; Compiler Options&#41;](https://msdn.microsoft.com/library/zekwfyz4.aspx).|
|**--preferreduilang:&lt;lang&gt;**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. -> for example,

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits to be fixed

@@ -52,6 +52,7 @@ Where lists appear in F# Interactive option arguments, list elements are separat
|**--nologo**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).|
|**--nowarn:&lt;warning-list&gt;**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).|
|**--optimize**[**+**&#124;**-**]|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).|
|**--preferreduilang:&lt;lang&gt;**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -94,5 +94,5 @@ test

|Title|Description|
|-----|-----------|
|[F# Interactive Options](fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.|
|[F# Interactive Options](../../language-reference/fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command line -> command-line

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge it when build finishes

@cartermp
Copy link
Contributor Author

🎉

@cartermp
Copy link
Contributor Author

öööf that build is taking a while

@mairaw mairaw closed this Jan 26, 2018
@mairaw mairaw reopened this Jan 26, 2018
@mairaw
Copy link
Contributor

mairaw commented Jan 26, 2018

The webhook seems to be failing for this PR. Not sure why. I can open a LSI in the morning if the issue persists.

@JRAlexander
Copy link
Contributor

Build still hung. Closing and reopening.

@JRAlexander JRAlexander reopened this Jan 26, 2018
@JRAlexander
Copy link
Contributor

JRAlexander commented Jan 26, 2018

Submitted LSI.

@Banani-Rath Banani-Rath reopened this Jan 27, 2018
@Banani-Rath Banani-Rath reopened this Jan 27, 2018
@cartermp cartermp closed this Jan 29, 2018
@cartermp cartermp reopened this Jan 29, 2018
@cartermp cartermp closed this Jan 29, 2018
@cartermp cartermp reopened this Jan 29, 2018
@cartermp cartermp closed this Jan 29, 2018
@cartermp cartermp reopened this Jan 29, 2018
@JRAlexander JRAlexander merged commit 172d1c6 into dotnet:master Jan 29, 2018
@cartermp cartermp deleted the preferreduilang branch January 29, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants