Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CommandLine): examples #41823

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(CommandLine): examples #41823

merged 2 commits into from
Jul 26, 2024

Conversation

vernou
Copy link
Contributor

@vernou vernou commented Jul 18, 2024 •
edited by github-actions bot
Loading

Summary

  • Modify a example to the async main await the main taks.
  • Fix a example to run the example program

Fixes #40757 (and its duplicate dotnet/command-line-api#2427)

Internal previews

📄 File 🔗 Preview link
docs/standard/commandline/get-started-tutorial.md Tutorial: Get started with System.CommandLine

@vernou vernou requested a review from tdykstra as a code owner July 18, 2024 11:46
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 18, 2024
@vernou vernou mentioned this pull request Jul 18, 2024
Closed
tdykstra
tdykstra reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a suggestion for a clarification.

docs/standard/commandline/get-started-tutorial.md Outdated Show resolved Hide resolved
@vernou @tdykstra
Improve for clarification
d30804c 
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@vernou vernou mentioned this pull request Jul 25, 2024
Open
@vernou
Copy link
Contributor Author

vernou commented Jul 26, 2024

@tdykstra, what is the next step?

@tdykstra tdykstra merged commit e222d75 into dotnet:main Jul 26, 2024
9 checks passed
@tdykstra
Copy link
Contributor

@tdykstra, what is the next step?

The next step was for me to merge it, which I just now did. Thanks for contributing this.

@vernou
Copy link
Contributor Author

vernou commented Jul 26, 2024

Ok, you are welcome.

@vernou vernou deleted the 40757-fix-example branch July 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.

Fix dotnet run example in System.CommandLine tutorial
3 participants
@vernou @tdykstra @dotnet-bot