Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference and conceptual content for ref struct allowed in interfaces #41777

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Jul 16, 2024

Contributes to #41206 (A following PR will add updated compiler diagnostics.)

Fixes other issues in the articles that were modified by this PR:

Fixes #33689: Update description of AssemblyFlagsAttribute.
Fixes #41392: Add allowed access modifiers on interface declarations and interface member declarations.
Fixes #39364: Add a definition of "base interface".
Fixes #40268: Update multiple constraints sample
Fixes #41761: Define "method group"

Commit details:

  1. Publish speclet.
  2. Add language reference for new syntax allow ref struct, and rules for ref struct types implementing an interface.
  3. Add note on interfaces that default interface members must be implemented by ref struct types that implement that interface.
  4. Edit pass and fix existing issues.
  5. Update the what's new page.

Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/attributes/general.md Miscellaneous attributes interpreted by the C# compiler
docs/csharp/language-reference/attributes/global.md "Attributes interpreted by the compiler: Global attributes"
docs/csharp/language-reference/builtin-types/ref-struct.md ref structure types (C# reference)
docs/csharp/language-reference/keywords/index.md C# Keywords
docs/csharp/language-reference/keywords/interface.md :::no-loc text="interface"::: (C# Reference)
docs/csharp/language-reference/keywords/where-generic-type-constraint.md where (generic type constraint) (C# Reference)
docs/csharp/programming-guide/generics/constraints-on-type-parameters.md Constraints on type parameters (C# Programming Guide)
docs/csharp/whats-new/csharp-13.md docs/csharp/whats-new/csharp-13

Update config to publish the new speclet for ref struct interfaces.
clarify source and binary break.

Turn on preview
Address open issues on all affected articles, perform a general edit pass.
@BillWagner BillWagner requested a review from adegeo July 26, 2024 20:44
@BillWagner
Copy link
Member Author

ping @adegeo for review.

@BillWagner BillWagner marked this pull request as ready for review July 26, 2024 20:44
@BillWagner BillWagner requested a review from a team as a code owner July 26, 2024 20:44
Update the what's new page with pointers to the new content.
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor things to consider.

Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
@BillWagner BillWagner merged commit d19ced2 into dotnet:main Jul 29, 2024
8 checks passed
@BillWagner BillWagner deleted the allow-ref-struct branch July 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment