Skip to content

Remove unnecessary section on getting fx symbols for perfcollect #39200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jan 19, 2024

Summary

Remove unnecessary section of the doc


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/trace-perfcollect-lttng.md Trace .NET applications with PerfCollect

@hoyosjs hoyosjs requested review from brianrob and a team January 19, 2024 01:06
@hoyosjs hoyosjs requested review from tommcdon and a team as code owners January 19, 2024 01:06
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing these docs! Should we include a pointer to dotnet-symbol for downloading CoreCLR native symbols?

@brianrob
Copy link
Member

Thanks @hoyosjs! Looks good. Also, @tommcdon, it looks like there are already instructions for downloading native symbols here: https://review.learn.microsoft.com/en-us/dotnet/core/diagnostics/trace-perfcollect-lttng?branch=pr-en-us-39200#get-symbols-for-the-native-runtime.

@IEvangelist IEvangelist merged commit 657f240 into main Jan 22, 2024
@IEvangelist IEvangelist deleted the hoyosjs-patch-1 branch January 22, 2024 13:59
BillWagner added a commit that referenced this pull request Jan 25, 2024
* Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement

 Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html

Please review and merge this PR to complete the process of onboarding to the new service.

* Deleting fabricbot.json

* Fill in missing scheduled search description. De-dupe Admin/Write permission check.

* .NET 9 Preview 1 breaking changes (#39198)

* Explains how protected internal works with the virtual and override keywords in different assemblies. (#39192)

* Update protected-internal.md

* Updates the sub-header

* Makes the comment line length shorter

* Apply suggestions from code review

---------

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

* Update package index with latest published versions (#39207)

* Add third option for collection expressions analyzers (#39199)

* Update package index with latest published versions (#39209)

* Add assembly attributes using project file (#39208)

* Update types.md (#39214)

There was some duplicate(?) code, demonstrating the creation of two Point instances twice. Surely, no need for this?

* Remove unnecessary section on getting fx symbols for perfcollect (#39200)

* Remove unnecessary section on getting fx symbols for perfcollect

* Remove hanging link

* Explain how to run MSTestRunner tests in VsCode (#39155)

* Explain how to run MSTestRunner tests in VsCode

* Add the run MSTestRunner with VSCode section

* Changes to MSTestRunner document

- Change TIP to a NOTE
- Fix header title

* Fix compilation error for AppLogEvents example (#39206)

* Use 'entry' word instead of 'key' for TLS in network programming (#39139)

* Clarify stateless worker routing rules (#39210)

* Clarify stateless worker routing rules

* Update date

* Update docs/orleans/grains/stateless-worker-grains.md

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* When I made the fix in this PR: #38713 I didn't notice one additional place that needed to be changed (#38964)

Co-authored-by: Maoni0 <maoni@microsoft.com>

* Create webapi app rather than webapp. (#39098)

* Explain how to solve "It was not possible to find any compatible fram… (#38937)

* Explain how to solve "It was not possible to find any compatible framework version."

Occurs when DOTNET_ROOT is pointing to another install such as 5.0.23, but the dotnet-dump expects a more recent release such as 6 or 7.

* Update docs/core/diagnostics/faq-dumps.yml

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

---------

Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* .NET dependabot-bot automated PR. (#39213)

Co-authored-by: BillWagner <BillWagner@users.noreply.github.com>

* Update package index with latest published versions (#39217)

* Update package index with latest published versions (#39218)

* Reduce metric name text size (#39211)

* Update package index with latest published versions (#39220)

* Update diagnostic default verbosity (#39215)

Co-authored-by: Marco Rossignoli <mrossignol@microsoft.com>

* Correct the typo: TreatWarningsAsErrors -> WarningsAsError (#39219)

* Update package index with latest published versions (#39225)

* Update package index with latest published versions (#39229)

* Bump Microsoft.ML.TensorFlow and Microsoft.ML

Bumps [Microsoft.ML.TensorFlow](https://github.com/dotnet/machinelearning) and [Microsoft.ML](https://github.com/dotnet/machinelearning). These dependencies needed to be updated together.

Updates `Microsoft.ML.TensorFlow` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

Updates `Microsoft.ML` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML.TensorFlow
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump System.Linq.Dynamic.Core

Bumps [System.Linq.Dynamic.Core](https://github.com/zzzprojects/System.Linq.Dynamic.Core) from 1.3.7 to 1.3.8.
- [Release notes](https://github.com/zzzprojects/System.Linq.Dynamic.Core/releases)
- [Changelog](https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/CHANGELOG.md)
- [Commits](zzzprojects/System.Linq.Dynamic.Core@v1.3.7...v1.3.8)

---
updated-dependencies:
- dependency-name: System.Linq.Dynamic.Core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML.ImageAnalytics

Bumps [Microsoft.ML.ImageAnalytics](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML.ImageAnalytics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/upload-artifact from 4.1.0 to 4.3.0

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.3.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@1eb3cb2...26f96df)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML.FastTree and Microsoft.ML

Bumps [Microsoft.ML.FastTree](https://github.com/dotnet/machinelearning) and [Microsoft.ML](https://github.com/dotnet/machinelearning). These dependencies needed to be updated together.

Updates `Microsoft.ML.FastTree` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

Updates `Microsoft.ML` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML.FastTree
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump System.Linq.Dynamic.Core

Bumps [System.Linq.Dynamic.Core](https://github.com/zzzprojects/System.Linq.Dynamic.Core) from 1.3.7 to 1.3.8.
- [Release notes](https://github.com/zzzprojects/System.Linq.Dynamic.Core/releases)
- [Changelog](https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/CHANGELOG.md)
- [Commits](zzzprojects/System.Linq.Dynamic.Core@v1.3.7...v1.3.8)

---
updated-dependencies:
- dependency-name: System.Linq.Dynamic.Core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML.Recommender and Microsoft.ML

Bumps [Microsoft.ML.Recommender](https://github.com/dotnet/machinelearning) and [Microsoft.ML](https://github.com/dotnet/machinelearning). These dependencies needed to be updated together.

Updates `Microsoft.ML.Recommender` from 0.21.0 to 0.21.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

Updates `Microsoft.ML` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML.Recommender
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML

Bumps [Microsoft.ML](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML.TimeSeries and Microsoft.ML

Bumps [Microsoft.ML.TimeSeries](https://github.com/dotnet/machinelearning) and [Microsoft.ML](https://github.com/dotnet/machinelearning). These dependencies needed to be updated together.

Updates `Microsoft.ML.TimeSeries` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

Updates `Microsoft.ML` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML.TimeSeries
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML

Bumps [Microsoft.ML](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML

Bumps [Microsoft.ML](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML

Bumps [Microsoft.ML](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.ML

Bumps [Microsoft.ML](https://github.com/dotnet/machinelearning) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/dotnet/machinelearning/releases)
- [Commits](https://github.com/dotnet/machinelearning/commits)

---
updated-dependencies:
- dependency-name: Microsoft.ML
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix template name (#39252)

Fixes #39237

When I renamed the template to put it last in the list, I didn't update the config option. This fixes that.

* Erroneous semicolon causes CS1513 compile error (#39251)

* Add some clarifications around C++/CLI projects (#39228)

* Update article

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* minor

---------

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Correct ubuntu and debian dependencies (#39253)

* Update linux-ubuntu.md

* Update linux-debian.md

* Update linux-ubuntu.md

* Update linux-ubuntu-2204.md

* Update linux-ubuntu-2004.md

* Update linux-ubuntu-2210.md

* Update linux-ubuntu-2304.md

* Update linux-ubuntu-2310.md

* Update package index with latest published versions (#39255)

* Update package index with latest published versions (#39256)

* Options validate onstart (#39254)

* Touch ms.date

* Add validate on start details

* Update MSTest runner extensions info (#39152)

* Update MSTest runner extensions info

- List licensing model for each extension
- Fix Code Coverage command line options
- Use released versions

* Apply suggestions from code review

* More coverage documentation

* Update docs/core/testing/unit-testing-mstest-runner-extensions.md

* Update docs/core/testing/unit-testing-mstest-runner-extensions.md

* Apply suggestions from code review

* Update extensions

* Fix broken links

---------

Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dotnet-policy-service[bot] <123482357+dotnet-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Marius Riis Haugan <55443722+marius-haugan@users.noreply.github.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
Co-authored-by: Artur Spychaj <drognanar@gmail.com>
Co-authored-by: Nikanoras Zavadskij <37303011+Nikanoras@users.noreply.github.com>
Co-authored-by: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com>
Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Maoni Stephens <Maoni0@users.noreply.github.com>
Co-authored-by: Maoni0 <maoni@microsoft.com>
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Co-authored-by: Guido Leenders <guido.leenders@invantive.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: BillWagner <BillWagner@users.noreply.github.com>
Co-authored-by: James Newton-King <james@newtonking.com>
Co-authored-by: Marco Rossignoli <marco.rossignoli@gmail.com>
Co-authored-by: Marco Rossignoli <mrossignol@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: surgicalcoder <surgicalcoder@users.noreply.github.com>
Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants