Skip to content

Conversation

@xaviex
Copy link
Contributor

@xaviex xaviex commented Oct 17, 2017

FWLink Standard Folder fix

Summary

FWLink Standard folder update to clarify links in the /docs/standard folder

Fixes #3425

Suggested Reviewers

@mairaw

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @xaviex! Really appreciate you tackling this. Again, please let me know if you'd like me to address the changes I'm requesting.

- When developing a pattern, you should consider how backtracking might affect the performance of the regular expression engine, particularly if your regular expression is designed to process unconstrained input. For more information, see the [Take Charge of Backtracking](#Backtracking) section.

- Thoroughly test your regular expression using invalid and near-valid input as well as valid input. To generate input for a particular regular expression randomly, you can use [Rex](http://go.microsoft.com/fwlink/?LinkId=210756), which is a regular expression exploration tool from Microsoft Research.
- Thoroughly test your regular expression using invalid and near-valid input as well as valid input. To generate input for a particular regular expression randomly, you can use [Rex](http://research.microsoft.com/en-us/projects/rex/), which is a regular expression exploration tool from Microsoft Research.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


> [!NOTE]
> For a more detailed discussion of the performance implications of using interpreted and compiled regular expressions, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://go.microsoft.com/fwlink/?LinkId=211566) in the BCL Team blog.
> For a more detailed discussion of the performance implications of using interpreted and compiled regular expressions, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://blogs.msdn.com/b/bclteam/archive/2010/06/25/optimizing-regular-expression-performance-part-i-working-with-the-regex-class-and-regex-objects.aspx) in the BCL Team blog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems even the forward link goes to the incorrect location, would we like this to be changed to the proper location or no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


> [!NOTE]
> For more information on backtracking, see [Details of Regular Expression Behavior](../../../docs/standard/base-types/details-of-regular-expression-behavior.md) and [Backtracking](../../../docs/standard/base-types/backtracking-in-regular-expressions.md). For a detailed discussion of backtracking, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://go.microsoft.com/fwlink/?LinkId=211567) in the BCL Team blog.
> For more information on backtracking, see [Details of Regular Expression Behavior](../../../docs/standard/base-types/details-of-regular-expression-behavior.md) and [Backtracking](../../../docs/standard/base-types/backtracking-in-regular-expressions.md). For a detailed discussion of backtracking, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://blogs.msdn.com/b/bclteam/archive/2010/08/03/optimizing-regular-expression-performance-part-ii-taking-charge-of-backtracking.aspx) in the BCL Team blog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|Visual Studio SKU|Support for creating a Portable Class Library|
|-----------------------|---------------------------------------------------|
|Visual Studio 2010, Professional, Premium, or Ultimate|Yes, when you install the [Portable Library Tools](http://go.microsoft.com/fwlink/?LinkId=210823).|
|Visual Studio 2010, Professional, Premium, or Ultimate|Yes, when you install the [Portable Library Tools](http://visualstudiogallery.msdn.microsoft.com/b0e0b5e9-e138-410b-ad10-00cb3caf4981/).|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, the Portable Class Library contains UI-related types only when you target Windows 8.1 and Windows Phone 8.1. Also, you may encounter limitations if you target platforms (such as Xbox, the .NET Framework 4, and Windows Phone 7) that were released before the introduction of the Portable Class Library. The .NET Framework releases packages through NuGet that improves the Portable Class Library support for some of these older platforms. For more information and a list of NuGet packages, see [The .NET Framework and Out-of-Band Releases](../../../docs/framework/get-started/the-net-framework-and-out-of-band-releases.md).

If a member is supported in the Portable Class Library and for your selected targets, it will appear in your project in IntelliSense. In addition, the Portable Class Library icon ![Supported by Portable Library](../../../docs/standard/cross-platform/media/portablelibrary-referenceicon.png "PortableLibrary_ReferenceIcon") appears in the members tables, in the [.NET Framework Class Library](http://go.microsoft.com/fwlink/?LinkId=211358) next to supported members. For example, the following members table shows that the <xref:System.String.Chars%2A> property in the <xref:System.String> class is supported in the Portable Class Library:
If a member is supported in the Portable Class Library and for your selected targets, it will appear in your project in IntelliSense. In addition, the Portable Class Library icon ![Supported by Portable Library](../../../docs/standard/cross-platform/media/portablelibrary-referenceicon.png "PortableLibrary_ReferenceIcon") appears in the members tables, in the [.NET Framework Class Library](http://msdn.microsoft.com/en-us/library/ms229335.aspx) next to supported members. For example, the following members table shows that the <xref:System.String.Chars%2A> property in the <xref:System.String> class is supported in the Portable Class Library:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right link would be https://msdn.microsoft.com/library/mt472912.aspx. I just updated in the tool too in case other pages are using this link

Isolated storage is a data storage mechanism that provides isolation and safety by defining standardized ways of associating code with saved data. The storage provides a virtual file system that is isolated by user, assembly, and (optionally) domain. Isolated storage is particularly useful when your application does not have permission to access user files. You can save settings or files for your application in a manner that is controlled by the computer's security policy.

Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps; instead, use application data classes in the [Windows.Storage](http://msdn.microsoft.com/library/windows/apps/windows.storage.aspx) namespace. For more information, see [Application data](http://go.microsoft.com/fwlink/?LinkId=229175) in the Windows Dev Center.
Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps; instead, use application data classes in the [Windows.Storage](http://msdn.microsoft.com/library/windows/apps/windows.storage.aspx) namespace. For more information, see [Application data](http://msdn.microsoft.com/en-us/library/windows/apps/hh464917.aspx) in the Windows Dev Center.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove en-us/ from the link

- Types specifically related to file operations, such as <xref:System.IO.File>, <xref:System.IO.FileInfo>, <xref:System.IO.Directory> and <xref:System.IO.DirectoryInfo>, are not included in the [!INCLUDE[net_win8_profile](../../../includes/net-win8-profile-md.md)]. Instead, use the types in the [Windows.Storage](http://msdn.microsoft.com/library/windows/apps/windows.storage.aspx) namespace of the [!INCLUDE[wrt](../../../includes/wrt-md.md)], such as [StorageFile](http://msdn.microsoft.com/library/windows/apps/windows.storage.storagefile.aspx) and [StorageFolder](http://msdn.microsoft.com/library/windows/apps/windows.storage.storagefolder.aspx).

- Isolated storage is not available; instead, use [application data](http://go.microsoft.com/fwlink/?LinkId=229175).
- Isolated storage is not available; instead, use [application data](http://msdn.microsoft.com/en-us/library/windows/apps/hh464917.aspx).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove en-us/ from the link

When you use the classes in the <xref:System.IO?displayProperty=nameWithType> namespace, you must follow operating system security requirements such as access control lists (ACLs) to control access to files and directories. This requirement is in addition to any <xref:System.Security.Permissions.FileIOPermission> requirements. You can manage ACLs programmatically. For more information, see [How to: Add or Remove Access Control List Entries](../../../docs/standard/io/how-to-add-or-remove-access-control-list-entries.md).

Default security policies prevent Internet or intranet applications from accessing files on the user’s computer. Therefore, do not use the I/O classes that require a path to a physical file when writing code that will be downloaded over the Internet or intranet. Instead, use [isolated storage](../../../docs/standard/io/isolated-storage.md) for traditional .NET Framework applications, or use [application data](http://go.microsoft.com/fwlink/?LinkId=229175) for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps.
Default security policies prevent Internet or intranet applications from accessing files on the user’s computer. Therefore, do not use the I/O classes that require a path to a physical file when writing code that will be downloaded over the Internet or intranet. Instead, use [isolated storage](../../../docs/standard/io/isolated-storage.md) for traditional .NET Framework applications, or use [application data](http://msdn.microsoft.com/en-us/library/windows/apps/hh464917.aspx) for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove en-us from the link


> [!IMPORTANT]
> Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps. Instead, use the application data classes in the `Windows.Storage` namespaces included in the [!INCLUDE[wrt](../../../includes/wrt-md.md)] API to store local data and files. For more information, see [Application data](http://go.microsoft.com/fwlink/?LinkId=229175) in the Windows Dev Center.
> Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps. Instead, use the application data classes in the `Windows.Storage` namespaces included in the [!INCLUDE[wrt](../../../includes/wrt-md.md)] API to store local data and files. For more information, see [Application data](http://msdn.microsoft.com/en-us/library/windows/apps/hh464917.aspx) in the Windows Dev Center.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove en-us from the link


> [!IMPORTANT]
> Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps. Instead, use the application data classes in the `Windows.Storage` namespaces included in the [!INCLUDE[wrt](../../../includes/wrt-md.md)] API to store local data and files. For more information, see [Application data](http://go.microsoft.com/fwlink/?LinkId=229175) in the Windows Dev Center.
> Isolated storage is not available for [!INCLUDE[win8_appname_long](../../../includes/win8-appname-long-md.md)] apps. Instead, use the application data classes in the `Windows.Storage` namespaces included in the [!INCLUDE[wrt](../../../includes/wrt-md.md)] API to store local data and files. For more information, see [Application data](http://msdn.microsoft.com/en-us/library/windows/apps/hh464917.aspx) in the Windows Dev Center.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@mairaw mairaw added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Oct 17, 2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


> [!NOTE]
> For a more detailed discussion of the performance implications of using interpreted and compiled regular expressions, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://go.microsoft.com/fwlink/?LinkId=211566) in the BCL Team blog.
> For a more detailed discussion of the performance implications of using interpreted and compiled regular expressions, see [Optimizing Regular Expression Performance, Part II: Taking Charge of Backtracking](http://blogs.msdn.com/b/bclteam/archive/2010/06/25/optimizing-regular-expression-performance-part-i-working-with-the-regex-class-and-regex-objects.aspx) in the BCL Team blog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaviex
Copy link
Contributor Author

xaviex commented Oct 17, 2017

@mairaw I have cleaned up that odd-looking link, where there any other discrepancies?

@mairaw mairaw removed the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Oct 17, 2017
@xaviex
Copy link
Contributor Author

xaviex commented Oct 17, 2017

It has come to my attention that this has actually removed more localization than was in the link replacements, is this ok?

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. The global changes to remove en-us from the links generated a new set of feedback @xaviex. In general, I'd recommend we solve one issue per PR. Let me know if you need help addressing the comments. Thanks again!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebJobs link now actually goes here: https://github.com/Azure/azure-webjobs-sdk/wiki

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scale sets link now goes here: https://docs.microsoft.com/azure/virtual-machine-scale-sets/ (and in the case of the e-books we keep the docs URL)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner this link doesn't seem to exist. delete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change For link to ~/docs/visual-basic/language-reference/statements/for-each-next-statement.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's a missing space before the link if you'd like to fix that

@mairaw mairaw changed the title Standard Folder FWLink List 📝 Standard Folder FWLink List Oct 18, 2017
@xaviex
Copy link
Contributor Author

xaviex commented Oct 18, 2017

the removal of en-us was actually accidental on my part, I can re do it only changing the links that used to be fwlinks?

@xaviex
Copy link
Contributor Author

xaviex commented Oct 18, 2017

@mariaw Would you like me to create a new pull request with the basic changes along with what you have commented on here?

@mairaw
Copy link
Contributor

mairaw commented Oct 19, 2017

No need to open a new PR. We could probably just pull out the commit you made that change from this PR. I'll do that.

@xaviex
Copy link
Contributor Author

xaviex commented Oct 19, 2017

@mairaw Was that change made I can not tell?

@mairaw
Copy link
Contributor

mairaw commented Oct 20, 2017

I've removed that commit now @xaviex.

@dotnet dotnet deleted a comment from dnfclas Oct 31, 2017
@mairaw
Copy link
Contributor

mairaw commented Nov 6, 2017

@xaviex do you want to take care of the remainder comments or do you want me to address them? Sorry this PR has been lingering here but I was out for the past couple of weeks.

@xaviex
Copy link
Contributor Author

xaviex commented Nov 7, 2017

@mairaw Ive got this, should be pushing it in a day or two

@mairaw
Copy link
Contributor

mairaw commented Nov 9, 2017

Thank you @xaviex!

@BillWagner
Copy link
Member

@xaviex Are you still planning to make those final changes? If not, we'll address them and merge your PR.

Thanks again for contributing.

@xaviex
Copy link
Contributor Author

xaviex commented Nov 20, 2017 via email

@xaviex
Copy link
Contributor Author

xaviex commented Dec 2, 2017

@mairaw Hey my apologies, it doesn't look like I'm going to be able to get to this within the next week or so, work got very hectic recently, thanks for all the help

@mairaw
Copy link
Contributor

mairaw commented Dec 2, 2017

No worries @xaviex. I'll see what the remaining comments were and finish this PR. Thanks a bunch!

@mairaw mairaw merged commit 4ddadd3 into dotnet:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace FwLinks with the actual target links - standard folder

5 participants