Skip to content

Update .NET install scripts reference #32348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Update .NET install scripts reference #32348

merged 1 commit into from
Nov 8, 2022

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Nov 8, 2022

Fixes #32347

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit 3e57453 into main Nov 8, 2022
@IEvangelist IEvangelist deleted the tdykstra-patch-1 branch November 8, 2022 21:07
@@ -100,8 +100,8 @@ The install scripts do not update the registry on Windows. They just download th

Specifies the source channel for the installation. The possible values are:

- `Current` - Most current release.
- `LTS` - Long-Term Support channel (most current supported release).
- `STS` - Standard Term Support SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no "SDK" after Standard Term Support

Copy link
Contributor Author

@tdykstra tdykstra Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it, but note that this was taken verbatim from the scripts themselves, so the scripts should be updated also.

- `Current` - Most current release.
- `LTS` - Long-Term Support channel (most current supported release).
- `STS` - Standard Term Support SDK
- `LTS` - The most current Long Term Support release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets replace the word "current" with recent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change too should be made in the scripts themselves as well.

@tdykstra
Copy link
Contributor Author

tdykstra commented Nov 8, 2022

@YuliiaKovalova Note changes to --channel help text.

@YuliiaKovalova
Copy link
Member

Hi @tdykstra ,

The PR with changes is ready.
dotnet/install-scripts#330
I think we can deploy it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update --channel current --> sts
5 participants