-
Notifications
You must be signed in to change notification settings - Fork 6k
Update .NET install scripts reference #32348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we'll - thank you 🙏
@@ -100,8 +100,8 @@ The install scripts do not update the registry on Windows. They just download th | |||
|
|||
Specifies the source channel for the installation. The possible values are: | |||
|
|||
- `Current` - Most current release. | |||
- `LTS` - Long-Term Support channel (most current supported release). | |||
- `STS` - Standard Term Support SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no "SDK" after Standard Term Support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it, but note that this was taken verbatim from the scripts themselves, so the scripts should be updated also.
- `Current` - Most current release. | ||
- `LTS` - Long-Term Support channel (most current supported release). | ||
- `STS` - Standard Term Support SDK | ||
- `LTS` - The most current Long Term Support release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets replace the word "current" with recent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change too should be made in the scripts themselves as well.
@YuliiaKovalova Note changes to --channel help text. |
Hi @tdykstra , The PR with changes is ready. |
Fixes #32347