Skip to content

Add --duration doc for dotnet-trace fixes #32088 #32089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

alex-jitbit
Copy link
Contributor

Summary

Adds the missing --duration command option description

Fixes #32088

@alex-jitbit alex-jitbit requested review from tommcdon and a team as code owners October 30, 2022 17:45
@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 30, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 30, 2022
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except --duration should be added in the Synopsis section also.

@BillWagner
Copy link
Member

@alex-jitbit

Can you make the one change requested? Then, we'll merge this.

@BillWagner BillWagner self-assigned this Nov 9, 2022
@alex-jitbit
Copy link
Contributor Author

alex-jitbit commented Nov 10, 2022

@BillWagner Added. But are you sure this option works with other commands too? I have tested it with collect only. If you are - then fine

The option was added in the wrong location.
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM.

I'll :shipit: when the build finishies.

@BillWagner
Copy link
Member

@BillWagner Added. But are you sure this option works with other commands too? I have tested it with collect only. If you are - then fine

It does only apply for the collect subcommand. Rather than the opening paragraph, we meant the synoposis location. I made the edit, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) November 10, 2022 14:32
@BillWagner BillWagner merged commit ddc053d into dotnet:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet-trace docs do not mention the --duration parameter
4 participants