Modify log scope to use keyvalue pairs #32076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
tarekgh
approved these changes
Oct 28, 2022
cijothomas
added a commit
to cijothomas/AspNetCore.Docs
that referenced
this pull request
Oct 31, 2022
Rick-Anderson
pushed a commit
to dotnet/AspNetCore.Docs
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The scopes example currently uses a plain string. This PR proposes to replace that with a KVP collection, containing the key "TransactionId". This matches the example use case that was described right above the example code snippet.
While Scope can accept any
objectincludingstring, most backends expect additional enrichments to come in the form of key-value pairs, so this is demonstrating a better practice of using Scopes.Fixes #Issue_Number (if available)