Removed: await finishedTask; #32059
Merged
Removed: await finishedTask; #32059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task was awaited on line 231.
ghost
added
the
community-contribution
IEvangelist
approved these changes
Oct 27, 2022
- thank you 🙏
|
I think Await finishedTask shouldn't be deleted. Await finishedTask was executed after receiving the already completed Task by Task.WhenAny. Therefore, waiting is not affected by execution time. Otherwise, exceptions that run asynchronously cannot be caught. Test the fire scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've removed the
await finishedTask;from line 244 because the task was awaited on line 231.