Skip to content

Fix PoliChek hit: Newfoundland #32007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix PoliChek hit: Newfoundland #32007

merged 1 commit into from
Oct 24, 2022

Conversation

v-thepet
Copy link
Contributor

Summary

User Story https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/2001296

The term is "Newfoundland". OK when referring to the island but not the province (Newfoundland and Labrador). This image could be a photo of the island, or of a map showing the province. I tracked down the image to Wikimedia Commons and it's actually a photo of an interior with a dresser. So I renamed the label to "dresser".

Fixes #Issue_Number (if available)
https://dev.azure.com/msft-skilling/Content/_workitems/edit/14585
https://dev.azure.com/msft-skilling/Content/_workitems/edit/14619
https://dev.azure.com/msft-skilling/Content/_workitems/edit/14609
https://dev.azure.com/msft-skilling/Content/_workitems/edit/14732

@v-thepet
Copy link
Contributor Author

#sign-off

@IEvangelist IEvangelist merged commit c54812d into dotnet:main Oct 24, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 26, 2022
@gewarren
Copy link
Contributor

@v-thepet I'm curious how you tracked the image down - can you point me to it? Also, I'm not sure that these assets are actually used anywhere. The link to download the assets seems to point to the dotnet/samples repo now (which still contains the flagged term).
Finally, I'm guessing that "Newfoundland" in this case was referring to the dog breed, since the other images in the vicinity are either dog breeds or animals.
cc @luisquintanilla

@v-thepet
Copy link
Contributor Author

v-thepet commented Oct 26, 2022

@gewarren @luisquintanilla - Here's what I think is that image: https://commons.wikimedia.org/wiki/File:Newfoundland_108_(2634775216).jpg. To find that, I backtracked from the images that are being used in the tutorial. You are right that most of them aren't being used, but the ones that are, all pointed to locations on wikimedia commons. The image filenames aren't exactly equivalent to the labels in the lists.

You're also correct that in the sample repo or in other places where this Tensorflow dataset is available, the Newfoundland label remains. The aim in this PoliChek work item is to get rid of the term in the Microsoft docs if possible, to avoid future hits, even if it's being used in a context that isn't technically incorrect. I figured this usage was inconsequential, so I changed it.

You're right that the surrounding labels all apply to animals and dog breeds. I didn't pick up on that because the whole list has many things including other furniture, but they're all later in the list. Not sure if it's supposed to be in any order or not. One thing I could do would be change it to "Newfie" which is a apparently a nickname for the breed. Should I do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-ml/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants