Skip to content

Clarify nesting of config switch #31509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

gewarren
Copy link
Contributor

Related to #27713.

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@BillWagner BillWagner merged commit a7a1fd1 into dotnet:main Sep 30, 2022
@filipnavara
Copy link
Member

filipnavara commented Dec 3, 2022

Why was ImageSharp removed from the recommendations? There's no explanation in the commit info or in the PR.

UPD: Hmm, somehow it's not mentioned here but it's mentioned at dotnet/dotnet-api-docs#8577.

@tarekgh
Copy link
Member

tarekgh commented Dec 4, 2022

CC @richlander for the question #31509 (comment).

@terrajobst
Copy link
Contributor

@filipnavara

There is a follow up regarding this policy here: #32861

@terrajobst
Copy link
Contributor

We have provided a rationale in the corresponding PR in dotnet-api-docs: dotnet/dotnet-api-docs#8577

@terrajobst
Copy link
Contributor

terrajobst commented Dec 5, 2022

Locking this thread as the discussion should be happening in any of the linked conversations above. Thanks!

@dotnet dotnet locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants