Skip to content

fix/replace links #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 10, 2017
Merged

fix/replace links #2822

merged 12 commits into from
Aug 10, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 2, 2017

In PR #2780, @rpetrusha noticed we had quite a few API links still going to MSDN. I found a couple more not related to the feedback he was giving, so fixing some obvious ones on this PR + a few other broken/msdn links.

Related to #2580.

@rpetrusha
Copy link
Contributor

An unspecified error occurred during the build; closing and reopening to restart build.

@rpetrusha
Copy link
Contributor

@mairaw, the build has failed twice, so I suspect that one of the changes has caused the build break. I've looked through your changes, though, and I can't identify anything that might cause a build break.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at all the diffs, and everything looks good.

Let's :shipit: once we figure out why this build is failing.

* <xref:System.Decimal?displayProperty=fullName> ([decimal](../csharp/language-reference/keywords/decimal.md)) - A 128-bit decimal type.
* <xref:System.Byte?displayProperty=fullName> ([byte](../csharp/language-reference/keywords/byte.md)) - An unsigned 8-bit integer that represents a byte of memory.
* <xref:System.Boolean?displayProperty=fullName> ([bool](../csharp/language-reference/keywords/bool.md)) - A boolean type that represents ‘true’ or ‘false’.
* <xref:?displayProperty=fullName> ([char](../csharp/language-reference/keywords/char.md)) - A 16-bit numeric type that represents a Unicode character.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty uid, should be <xref:char?displayProperty=fullName>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vicancy!

@mairaw mairaw merged commit 934373d into dotnet:master Aug 10, 2017
@mairaw mairaw deleted the fix-links branch August 10, 2017 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants