Skip to content

File.Replace exceptions on Unix #26505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

File.Replace exceptions on Unix #26505

merged 1 commit into from
Oct 19, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 14, 2021 •
edited
Loading

Fixes #26323

Preview

@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 14, 2021
@gewarren gewarren requested review from carlossanlop and a team October 14, 2021 00:51
BillWagner
BillWagner approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when you're ready.

@gewarren gewarren merged commit 3d3722b into dotnet:main Oct 19, 2021
@gewarren gewarren deleted the file-replace branch October 19, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@jozkee jozkee Awaiting requested review from jozkee

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

[Breaking Change] File.Replace throws exceptions on more cases on Unix
3 participants
@gewarren @BillWagner @dotnet-bot