Update nullable reference types for C# 10 #25883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
nullables-csharp10
branch
from
3fe91a8 to
d300336
Compare
IEvangelist
reviewed
Sep 1, 2021
Apply suggestions from code review Co-authored-by: David Pine <david.pine@microsoft.com> final edit
BillWagner
force-pushed
the
nullables-csharp10
branch
2 times, most recently
from
b569f6c to
8d6a0da
Compare
Provide a more detailed description and recommendations on using the different settings for annotations and warnings in a nullable context.
BillWagner
force-pushed
the
nullables-csharp10
branch
from
8d6a0da to
26a0421
Compare
Fix descriptions of the warnings and annotations settings for nullable contexts.
BillWagner
force-pushed
the
nullables-csharp10
branch
from
be619a6 to
d2bdacb
Compare
IEvangelist
approved these changes
Sep 2, 2021
Co-authored-by: David Pine <david.pine@microsoft.com>
|
@BillWagner I think this introduced some bad lint. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of changes here:
First two commits: I reworked the conceptual article to focus on the compiler's static analysis instead of the addition of nullable reference types as a type. That addresses many of the misconceptions that led to the various issues fixed in this PR.
Fixes #21716
<nullable>enable</nullable>on by default.Third commit:
Fixes #24257
Fourth commit
Fixes #25027
Internal preview - nullable overview